Skip to content

Commit 233ae83

Browse files
authored
Remove search sorted many (#3247)
And test performance of search sorted using scalar_at
1 parent 0df49c3 commit 233ae83

File tree

28 files changed

+40
-1103
lines changed

28 files changed

+40
-1103
lines changed

encodings/fastlanes/src/bitpacking/compute/mod.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,13 @@
1-
use vortex_array::Array;
2-
use vortex_array::compute::SearchSortedFn;
31
use vortex_array::vtable::ComputeVTable;
42

53
use crate::BitPackedEncoding;
64

75
mod between;
86
mod filter;
97
mod is_constant;
10-
mod search_sorted;
118
mod take;
129

13-
impl ComputeVTable for BitPackedEncoding {
14-
fn search_sorted_fn(&self) -> Option<&dyn SearchSortedFn<&dyn Array>> {
15-
Some(self)
16-
}
17-
}
10+
impl ComputeVTable for BitPackedEncoding {}
1811

1912
fn chunked_indices<F: FnMut(usize, &[usize])>(
2013
mut indices: impl Iterator<Item = usize>,

encodings/fastlanes/src/bitpacking/compute/search_sorted.rs

Lines changed: 0 additions & 286 deletions
This file was deleted.

encodings/fastlanes/src/bitpacking/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ impl BitPackedArray {
230230
///
231231
/// Note that this value need not actually be present in the array.
232232
#[inline]
233-
fn max_packed_value(&self) -> usize {
233+
pub fn max_packed_value(&self) -> usize {
234234
(1 << self.bit_width()) - 1
235235
}
236236
}

0 commit comments

Comments
 (0)