Skip to content

Commit 2819984

Browse files
fix[bench]: better bench input size (#4243)
Signed-off-by: Joe Isaacs <[email protected]>
1 parent f547cbc commit 2819984

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

vortex-buffer/benches/vortex_buffer.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@ impl<T: ArrowNativeType> FromIterator<T> for Arrow<MutableBuffer> {
3030
}
3131
}
3232

33+
const INPUT_SIZE: &[i32] = &[128, 1024, 2048, 16_384, 65_536];
34+
const INPUT_SIZE_USIZE: &[usize] = &[128, 1024, 2048, 16_384, 65_536];
35+
3336
#[divan::bench(
3437
types = [Arrow<ScalarBuffer<i32>>,Buffer<i32>],
35-
args = [1, 100, 1_000, 100_000, 10_000_000],
38+
args = INPUT_SIZE,
3639
)]
3740
fn from_iter<B: FromIterator<i32>>(n: i32) {
3841
B::from_iter((0..n).map(|i| i % i32::MAX));
@@ -79,15 +82,15 @@ impl<T: Copy, R> MapEach<T, R> for BufferMut<T> {
7982

8083
#[divan::bench(
8184
types = [Arrow<ScalarBuffer<i32>>, BufferMut<i32>],
82-
args = [1, 100, 1_000, 100_000, 10_000_000],
85+
args = INPUT_SIZE,
8386
)]
8487
fn map_each<B: MapEach<i32, u32> + FromIterator<i32>>(bencher: Bencher, n: i32) {
8588
bencher
8689
.with_inputs(|| B::from_iter((0..n).map(|i| i % i32::MAX)))
8790
.bench_values(|buffer| B::map_each(buffer, |i| (i as u32) + 1));
8891
}
8992

90-
#[divan::bench(args = [100, 1_000, 10_000, 100_000, 1_000_000])]
93+
#[divan::bench(args = INPUT_SIZE)]
9194
fn push_vortex_buffer(bencher: Bencher, length: i32) {
9295
bencher
9396
.with_inputs(|| BufferMut::<i32>::with_capacity(length as usize))
@@ -98,7 +101,7 @@ fn push_vortex_buffer(bencher: Bencher, length: i32) {
98101
});
99102
}
100103

101-
#[divan::bench(args = [100, 1_000, 10_000, 100_000, 1_000_000])]
104+
#[divan::bench(args = INPUT_SIZE)]
102105
fn push_arrow_buffer(bencher: Bencher, length: i32) {
103106
bencher
104107
.with_inputs(|| {
@@ -113,7 +116,7 @@ fn push_arrow_buffer(bencher: Bencher, length: i32) {
113116
});
114117
}
115118

116-
#[divan::bench(types = [u8, u16, u32, u64], args = [100, 1_000, 10_000, 100_000, 1_000_000])]
119+
#[divan::bench(types = [u8, u16, u32, u64], args = INPUT_SIZE_USIZE)]
117120
fn push_n_vortex_buffer<T: PrimInt>(bencher: Bencher, length: usize) {
118121
bencher
119122
.with_inputs(|| BufferMut::<T>::with_capacity(length))

0 commit comments

Comments
 (0)