Remove clone from array vtable (#5552)

gatesn · web-flow · commit 32d834afb7b1 · 2025-11-26T21:35:27.000Z
Signed-off-by: Nicholas Gates &lt;nick@nickgates.com&gt;
diff --git a/encodings/alp/src/alp/array.rs b/encodings/alp/src/alp/array.rs
@@ -147,7 +147,7 @@ pub struct ALPArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ALPVTable;
 
 #[derive(Clone, prost::Message)]
diff --git a/encodings/alp/src/alp_rd/array.rs b/encodings/alp/src/alp_rd/array.rs
@@ -199,7 +199,7 @@ pub struct ALPRDArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ALPRDVTable;
 
 impl ALPRDArray {
diff --git a/encodings/bytebool/src/array.rs b/encodings/bytebool/src/array.rs
@@ -109,7 +109,7 @@ pub struct ByteBoolArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ByteBoolVTable;
 
 impl ByteBoolArray {
diff --git a/encodings/datetime-parts/src/array.rs b/encodings/datetime-parts/src/array.rs
@@ -154,7 +154,7 @@ pub struct DateTimePartsArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct DateTimePartsVTable;
 
 impl DateTimePartsArray {
diff --git a/encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs b/encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs
@@ -171,7 +171,7 @@ impl DecimalBytePartsArray {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct DecimalBytePartsVTable;
 
 impl BaseArrayVTable<DecimalBytePartsVTable> for DecimalBytePartsVTable {
diff --git a/encodings/fastlanes/src/bitpacking/vtable/mod.rs b/encodings/fastlanes/src/bitpacking/vtable/mod.rs
@@ -178,5 +178,5 @@ impl VTable for BitPackedVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct BitPackedVTable;
diff --git a/encodings/fastlanes/src/delta/vtable/mod.rs b/encodings/fastlanes/src/delta/vtable/mod.rs
@@ -101,7 +101,7 @@ impl VTable for DeltaVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct DeltaVTable;
 
 #[cfg(test)]
diff --git a/encodings/fastlanes/src/for/vtable/mod.rs b/encodings/fastlanes/src/for/vtable/mod.rs
@@ -91,7 +91,7 @@ impl VTable for FoRVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct FoRVTable;
 
 #[derive(Clone)]
diff --git a/encodings/fastlanes/src/rle/vtable/mod.rs b/encodings/fastlanes/src/rle/vtable/mod.rs
@@ -125,7 +125,7 @@ impl VTable for RLEVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct RLEVTable;
 
 #[cfg(test)]
diff --git a/encodings/fsst/src/array.rs b/encodings/fsst/src/array.rs
@@ -175,7 +175,7 @@ impl Debug for FSSTArray {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct FSSTVTable;
 
 impl FSSTArray {
diff --git a/encodings/pco/src/array.rs b/encodings/pco/src/array.rs
@@ -193,7 +193,7 @@ pub(crate) fn vortex_err_from_pco(err: PcoError) -> VortexError {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct PcoVTable;
 
 #[derive(Clone, Debug)]
diff --git a/encodings/runend/src/array.rs b/encodings/runend/src/array.rs
@@ -130,7 +130,7 @@ pub struct RunEndArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct RunEndVTable;
 
 impl RunEndArray {
diff --git a/encodings/sequence/src/array.rs b/encodings/sequence/src/array.rs
@@ -384,7 +384,7 @@ impl VisitorVTable<SequenceVTable> for SequenceVTable {
     fn visit_children(_array: &SequenceArray, _visitor: &mut dyn ArrayChildVisitor) {}
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct SequenceVTable;
 
 impl EncodeVTable<SequenceVTable> for SequenceVTable {
diff --git a/encodings/sparse/src/lib.rs b/encodings/sparse/src/lib.rs
@@ -148,7 +148,7 @@ pub struct SparseArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct SparseVTable;
 
 impl SparseArray {
diff --git a/encodings/zigzag/src/array.rs b/encodings/zigzag/src/array.rs
@@ -108,7 +108,7 @@ pub struct ZigZagArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ZigZagVTable;
 
 impl ZigZagArray {
diff --git a/encodings/zstd/src/array.rs b/encodings/zstd/src/array.rs
@@ -154,7 +154,7 @@ impl VTable for ZstdVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ZstdVTable;
 
 #[derive(Clone, Debug)]
diff --git a/vortex-array/src/arrays/bool/vtable/mod.rs b/vortex-array/src/arrays/bool/vtable/mod.rs
@@ -111,5 +111,5 @@ impl VTable for BoolVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct BoolVTable;
diff --git a/vortex-array/src/arrays/chunked/vtable/mod.rs b/vortex-array/src/arrays/chunked/vtable/mod.rs
@@ -137,5 +137,5 @@ impl VTable for ChunkedVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ChunkedVTable;
diff --git a/vortex-array/src/arrays/constant/vtable/mod.rs b/vortex-array/src/arrays/constant/vtable/mod.rs
@@ -31,7 +31,7 @@ mod visitor;
 
 vtable!(Constant);
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ConstantVTable;
 
 impl VTable for ConstantVTable {
diff --git a/vortex-array/src/arrays/decimal/vtable/mod.rs b/vortex-array/src/arrays/decimal/vtable/mod.rs
@@ -138,7 +138,7 @@ impl VTable for DecimalVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct DecimalVTable;
 
 #[cfg(test)]
diff --git a/vortex-array/src/arrays/dict/vtable/mod.rs b/vortex-array/src/arrays/dict/vtable/mod.rs
@@ -31,7 +31,7 @@ mod visitor;
 
 vtable!(Dict);
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct DictVTable;
 
 impl VTable for DictVTable {
diff --git a/vortex-array/src/arrays/expr/vtable/mod.rs b/vortex-array/src/arrays/expr/vtable/mod.rs
@@ -31,7 +31,7 @@ use crate::vtable::VTable;
 
 vtable!(Expr);
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ExprVTable;
 
 impl VTable for ExprVTable {
diff --git a/vortex-array/src/arrays/extension/vtable/mod.rs b/vortex-array/src/arrays/extension/vtable/mod.rs
@@ -86,5 +86,5 @@ impl VTable for ExtensionVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ExtensionVTable;
diff --git a/vortex-array/src/arrays/fixed_size_list/vtable/mod.rs b/vortex-array/src/arrays/fixed_size_list/vtable/mod.rs
@@ -33,7 +33,7 @@ mod visitor;
 
 vtable!(FixedSizeList);
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct FixedSizeListVTable;
 
 impl VTable for FixedSizeListVTable {
diff --git a/vortex-array/src/arrays/list/vtable/mod.rs b/vortex-array/src/arrays/list/vtable/mod.rs
@@ -113,5 +113,5 @@ impl VTable for ListVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ListVTable;
diff --git a/vortex-array/src/arrays/listview/vtable/mod.rs b/vortex-array/src/arrays/listview/vtable/mod.rs
@@ -38,7 +38,7 @@ mod visitor;
 
 vtable!(ListView);
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ListViewVTable;
 
 #[derive(Clone, prost::Message)]
diff --git a/vortex-array/src/arrays/masked/vtable/mod.rs b/vortex-array/src/arrays/masked/vtable/mod.rs
@@ -33,7 +33,7 @@ use crate::vtable::VisitorVTable;
 
 vtable!(Masked);
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct MaskedVTable;
 
 impl VisitorVTable<MaskedVTable> for MaskedVTable {
diff --git a/vortex-array/src/arrays/null/mod.rs b/vortex-array/src/arrays/null/mod.rs
@@ -123,7 +123,7 @@ pub struct NullArray {
     stats_set: ArrayStats,
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct NullVTable;
 
 impl NullArray {
diff --git a/vortex-array/src/arrays/primitive/vtable/mod.rs b/vortex-array/src/arrays/primitive/vtable/mod.rs
@@ -124,5 +124,5 @@ impl VTable for PrimitiveVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct PrimitiveVTable;
diff --git a/vortex-array/src/arrays/struct_/vtable/mod.rs b/vortex-array/src/arrays/struct_/vtable/mod.rs
@@ -123,5 +123,5 @@ impl VTable for StructVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct StructVTable;
diff --git a/vortex-array/src/arrays/varbin/vtable/mod.rs b/vortex-array/src/arrays/varbin/vtable/mod.rs
@@ -109,5 +109,5 @@ impl VTable for VarBinVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct VarBinVTable;
diff --git a/vortex-array/src/arrays/varbinview/vtable/mod.rs b/vortex-array/src/arrays/varbinview/vtable/mod.rs
@@ -125,5 +125,5 @@ impl VTable for VarBinViewVTable {
     }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct VarBinViewVTable;
diff --git a/vortex-array/src/arrow/array.rs b/vortex-array/src/arrow/array.rs
@@ -90,7 +90,7 @@ impl VTable for ArrowVTable {
 
 /// A Vortex array that wraps an in-memory Arrow array.
 // TODO(ngates): consider having each Arrow encoding be a separate encoding ID.
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct ArrowVTable;
 
 #[derive(Clone, Debug)]
diff --git a/vortex-array/src/vtable/mod.rs b/vortex-array/src/vtable/mod.rs
@@ -52,7 +52,7 @@ use crate::serde::ArrayChildren;
 /// implementations so do not need to be checked in the vtable implementations (for example, index
 /// out of bounds). Post-conditions are validated after invocation of the vtable function and will
 /// panic if violated.
-pub trait VTable: 'static + Sized + Send + Sync + Clone + Debug {
+pub trait VTable: 'static + Sized + Send + Sync + Debug {
     type Array: 'static + Send + Sync + Clone + Debug + Deref<Target = dyn Array> + IntoArray;
     type Metadata: Debug;
 
diff --git a/vortex-python/src/arrays/py/vtable.rs b/vortex-python/src/arrays/py/vtable.rs
@@ -48,10 +48,10 @@ vtable!(Python);
 
 /// Wrapper struct encapsulating a Python encoding.
 #[allow(dead_code)]
-#[derive(Clone, Debug)]
+#[derive(Debug)]
 pub struct PythonVTable {
     pub(super) id: ArrayId,
-    pub(super) cls: Arc<Py<PyType>>,
+    pub(super) cls: Py<PyType>,
 }
 
 /// Convert a Python class into a [`PythonVTable`].
@@ -75,7 +75,7 @@ impl<'py> FromPyObject<'_, 'py> for PythonVTable {
 
         Ok(PythonVTable {
             id,
-            cls: Arc::new(cls.to_owned().unbind()),
+            cls: cls.to_owned().unbind(),
         })
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ pub struct ALPArray {`
`147`	`147`	`stats_set: ArrayStats,`
`148`	`148`	`}`
`149`	`149`
`150`		`-#[derive(Clone, Debug)]`
	`150`	`+#[derive(Debug)]`
`151`	`151`	`pub struct ALPVTable;`
`152`	`152`
`153`	`153`	`#[derive(Clone, prost::Message)]`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ pub struct ALPRDArray {`
`199`	`199`	`stats_set: ArrayStats,`
`200`	`200`	`}`
`201`	`201`
`202`		`-#[derive(Clone, Debug)]`
	`202`	`+#[derive(Debug)]`
`203`	`203`	`pub struct ALPRDVTable;`
`204`	`204`
`205`	`205`	`impl ALPRDArray {`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ pub struct ByteBoolArray {`
`109`	`109`	`stats_set: ArrayStats,`
`110`	`110`	`}`
`111`	`111`
`112`		`-#[derive(Clone, Debug)]`
	`112`	`+#[derive(Debug)]`
`113`	`113`	`pub struct ByteBoolVTable;`
`114`	`114`
`115`	`115`	`impl ByteBoolArray {`
Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ pub struct DateTimePartsArray {`
`154`	`154`	`stats_set: ArrayStats,`
`155`	`155`	`}`
`156`	`156`
`157`		`-#[derive(Clone, Debug)]`
	`157`	`+#[derive(Debug)]`
`158`	`158`	`pub struct DateTimePartsVTable;`
`159`	`159`
`160`	`160`	`impl DateTimePartsArray {`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ impl DecimalBytePartsArray {`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`
`174`		`-#[derive(Clone, Debug)]`
	`174`	`+#[derive(Debug)]`
`175`	`175`	`pub struct DecimalBytePartsVTable;`
`176`	`176`
`177`	`177`	`impl BaseArrayVTable<DecimalBytePartsVTable> for DecimalBytePartsVTable {`
Original file line number	Diff line number	Diff line change
`@@ -178,5 +178,5 @@ impl VTable for BitPackedVTable {`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`
`181`		`-#[derive(Clone, Debug)]`
	`181`	`+#[derive(Debug)]`
`182`	`182`	`pub struct BitPackedVTable;`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ impl VTable for DeltaVTable {`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`
`104`		`-#[derive(Clone, Debug)]`
	`104`	`+#[derive(Debug)]`
`105`	`105`	`pub struct DeltaVTable;`
`106`	`106`
`107`	`107`	`#[cfg(test)]`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ impl VTable for FoRVTable {`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`
`94`		`-#[derive(Clone, Debug)]`
	`94`	`+#[derive(Debug)]`
`95`	`95`	`pub struct FoRVTable;`
`96`	`96`
`97`	`97`	`#[derive(Clone)]`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ impl VTable for RLEVTable {`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`
`128`		`-#[derive(Clone, Debug)]`
	`128`	`+#[derive(Debug)]`
`129`	`129`	`pub struct RLEVTable;`
`130`	`130`
`131`	`131`	`#[cfg(test)]`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ impl Debug for FSSTArray {`
`175`	`175`	`}`
`176`	`176`	`}`
`177`	`177`
`178`		`-#[derive(Clone, Debug)]`
	`178`	`+#[derive(Debug)]`
`179`	`179`	`pub struct FSSTVTable;`
`180`	`180`
`181`	`181`	`impl FSSTArray {`