Skip to content

Commit 366b694

Browse files
authored
Centralize all logging to tracing instead of log (#5670)
`tracing` has more structured logging support (see the changes I made in `btrblocks`) which is more suitable for modern observability tooling. It also has tracing support which is useful and already used in a few places. In python we use the tracing "log" feature which make it emit `log` events Signed-off-by: Adam Gutglick <[email protected]>
1 parent 3e1e65d commit 366b694

File tree

78 files changed

+250
-290
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+250
-290
lines changed

Cargo.lock

Lines changed: 26 additions & 49 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jiff = "0.2.0"
134134
kanal = "0.1.1"
135135
lending-iterator = "0.1.7"
136136
libfuzzer-sys = "0.4"
137-
log = { version = "0.4.21" }
137+
log = { version = "0.4" }
138138
loom = { version = "0.7", features = ["checkpoint"] }
139139
memmap2 = "0.9.5"
140140
mimalloc = "0.1.42"
@@ -184,7 +184,6 @@ serde_json = "1.0.116"
184184
serde_test = "1.0.176"
185185
simdutf8 = "0.1.5"
186186
similar = "2.7.0"
187-
simplelog = "0.12"
188187
sketches-ddsketch = "0.3.0"
189188
smol = "2.0.2"
190189
static_assertions = "1.1"
@@ -203,9 +202,9 @@ tokio-stream = "0.1.17"
203202
tokio-util = { version = "0.7.16" }
204203
tpchgen = { version = "2" }
205204
tpchgen-arrow = { version = "2" }
206-
tracing = { version = "0.1.41" }
205+
tracing = { version = "0.1.41", default-features = false }
207206
tracing-perfetto = "0.1.5"
208-
tracing-subscriber = "0.3.20"
207+
tracing-subscriber = "0.3"
209208
url = "2.5.7"
210209
uuid = { version = "1.18", features = ["js"] }
211210
walkdir = "2.5.0"

bench-vortex/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ glob = { workspace = true }
4747
humansize = { workspace = true }
4848
indicatif = { workspace = true, features = ["futures"] }
4949
itertools = { workspace = true }
50-
log = { workspace = true, features = ["max_level_debug"] }
5150
mimalloc = { workspace = true }
5251
noodles-bgzf = { workspace = true, features = ["async"] }
5352
noodles-vcf = { workspace = true, features = ["async"] }
@@ -74,7 +73,7 @@ tokio-stream = { workspace = true }
7473
tokio-util = { workspace = true }
7574
tpchgen = { workspace = true }
7675
tpchgen-arrow = { workspace = true }
77-
tracing = { workspace = true }
76+
tracing = { workspace = true, features = ["max_level_debug"] }
7877
tracing-perfetto = { workspace = true }
7978
tracing-subscriber = { workspace = true, features = [
8079
"env-filter",

bench-vortex/src/benchmark_driver.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use std::path::PathBuf;
88

99
use anyhow::Result;
1010
use indicatif::ProgressBar;
11-
use log::warn;
11+
use tracing::warn;
1212
use vortex::error::VortexExpect;
1313
use vortex_datafusion::metrics::VortexMetricsFinder;
1414

0 commit comments

Comments
 (0)