Skip to content

Commit 397d7f4

Browse files
authored
ci: Disable polar-signals deployments (#5790)
This PR disables deployment permissions for the polar-signals action. The current deployments create a ton of visual noise in long-running PRs (#5676) which makes it really hard to follow what's actually going on. I've added explicit deployment permission to actions that use github deployments (docs and publishing), and the polar-signals actions should still work even if it can't deploy. Signed-off-by: Adam Gutglick <[email protected]>
1 parent fb976a1 commit 397d7f4

File tree

6 files changed

+3
-4
lines changed

6 files changed

+3
-4
lines changed

.github/workflows/bench-pr.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ permissions:
1919
contents: read
2020
pull-requests: write # for commenting on PRs
2121
id-token: write # enables AWS-GitHub OIDC
22-
deployments: write # for Polar Signals profiling
2322

2423
jobs:
2524
label_trigger:

.github/workflows/bench.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ permissions:
1010
id-token: write # enables AWS-GitHub OIDC
1111
actions: read
1212
contents: write
13-
deployments: write
1413

1514
jobs:
1615
commit-metadata:

.github/workflows/docs.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ jobs:
5151
path: docs/_build/html
5252

5353
deploy:
54+
permissions:
55+
deployments: write
5456
environment:
5557
name: github-pages
5658
url: ${{ steps.deployment.outputs.page_url }}

.github/workflows/nightly-bench.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ permissions:
1515
id-token: write # enables AWS-GitHub OIDC
1616
actions: read
1717
contents: write
18-
deployments: write
1918

2019
jobs:
2120
sql:

.github/workflows/publish.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ jobs:
4646
timeout-minutes: 120
4747
permissions:
4848
id-token: write # IMPORTANT: mandatory for trusted publishing
49+
deployments: write
4950
environment:
5051
name: push-to-pypi
5152
url: https://pypi.org/p/vortex-data

.github/workflows/sql-pr.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ permissions:
1717
contents: read
1818
pull-requests: write # for commenting on PRs
1919
id-token: write # enables AWS-GitHub OIDC
20-
deployments: write # for Polar Signals profiling
2120

2221
jobs:
2322
label_trigger:

0 commit comments

Comments
 (0)