Skip to content

Commit 3b61edd

Browse files
authored
docs: how the vortex extension version is determined in ddb (#3135)
1 parent 608f2d9 commit 3b61edd

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

duckdb-vortex/Makefile

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,19 @@ PROJ_DIR := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))
22

33
EXT_NAME=vortex_duckdb
44
EXT_CONFIG=${PROJ_DIR}extension_config.cmake
5-
EXT_FLAGS=-DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 -DOVERRIDE_GIT_DESCRIBE=v1.2.2
5+
EXT_FLAGS=-DCMAKE_OSX_DEPLOYMENT_TARGET=12.0
66

77
export MACOSX_DEPLOYMENT_TARGET=12.0
8-
export VCPKG_OSX_DEPLOYMENT_TARGET=12.0
8+
9+
# The version of DuckDB and its Vortex extension is either implicitly set by Git tag, e.g. v1.2.2, or commit
10+
# SHA if the current commit does not have a tag. The implicitly set version can be overridden by defining the
11+
# `OVERRIDE_GIT_DESCRIBE` environment variable. In context of the DuckDB community extension build, we have to
12+
# rely on the Git tag, as DuckDB's CI performs a checkout by Git tag. Therefore, the version can't be explicitly
13+
# set via environment variable for the community extension build.
14+
15+
# export OVERRIDE_GIT_DESCRIBE=v1.2.2
916
export VCPKG_FEATURE_FLAGS=-binarycaching
17+
export VCPKG_OSX_DEPLOYMENT_TARGET=12.0
1018
export VCPKG_TOOLCHAIN_PATH := ${PROJ_DIR}vcpkg/scripts/buildsystems/vcpkg.cmake
1119

1220
include extension-ci-tools/makefiles/duckdb_extension.Makefile

0 commit comments

Comments
 (0)