Skip to content

Commit 40a541c

Browse files
committed
Faster pipelines
Signed-off-by: Nicholas Gates <[email protected]>
1 parent 348dc19 commit 40a541c

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

encodings/fastlanes/src/bitpacking/array/bitpack_pipeline.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ impl<BP: PhysicalPType<Physical: BitPacking>> Kernel for AlignedBitPackedKernel<
134134
debug_assert!(output.is_empty());
135135

136136
let packed_offset = self.num_chunks_unpacked * self.packed_stride;
137-
let not_yet_unpacked_values = &self.packed_buffer.as_slice()[packed_offset..];
137+
let packed_bytes = &self.packed_buffer[packed_offset..][..self.packed_stride];
138138

139139
// If the true count is very small (the selection is sparse), we can unpack individual
140140
// elements directly into the output vector.
@@ -151,7 +151,7 @@ impl<BP: PhysicalPType<Physical: BitPacking>> Kernel for AlignedBitPackedKernel<
151151
let unpacked_value = unsafe {
152152
BitPacking::unchecked_unpack_single(
153153
self.packed_bit_width,
154-
not_yet_unpacked_values,
154+
packed_bytes,
155155
idx,
156156
)
157157
};
@@ -179,7 +179,7 @@ impl<BP: PhysicalPType<Physical: BitPacking>> Kernel for AlignedBitPackedKernel<
179179
unsafe {
180180
BitPacking::unchecked_unpack(
181181
self.packed_bit_width,
182-
&not_yet_unpacked_values[..self.packed_stride],
182+
packed_bytes,
183183
transmute(elements.as_mut()),
184184
);
185185
}
@@ -200,13 +200,12 @@ impl<BP: PhysicalPType<Physical: BitPacking>> Kernel for AlignedBitPackedKernel<
200200

201201
#[cfg(test)]
202202
mod tests {
203+
use crate::BitPackedArray;
203204
use vortex_array::arrays::PrimitiveArray;
204205
use vortex_dtype::PTypeDowncast;
205206
use vortex_mask::Mask;
206207
use vortex_vector::VectorOps;
207208

208-
use crate::BitPackedArray;
209-
210209
#[test]
211210
fn test_bitpack_pipeline_basic() {
212211
// Create exactly 1024 elements (0 to 1023).

0 commit comments

Comments
 (0)