rename as_primitive -> cast

joseph-isaacs · joseph-isaacs · commit 4a897657f966 · 2025-11-05T13:58:20.000Z
Signed-off-by: Joe Isaacs &lt;joe.isaacs@live.co.uk&gt;
diff --git a/vortex-scalar/src/primitive.rs b/vortex-scalar/src/primitive.rs
@@ -995,7 +995,7 @@ mod tests {
         // Test f16 to f64 conversion
         assert!(f64::from_f16(f16_val).is_some());
 
-        // Test f16 to integer conversion (should fail)
+        // Test PValue::F16(f16) to integer conversion (should fail)
         assert!(i32::try_from(PValue::from(f16_val)).is_err());
         assert!(u32::try_from(PValue::from(f16_val)).is_err());
     }

Original file line number	Diff line number	Diff line change
`@@ -995,7 +995,7 @@ mod tests {`
`995`	`995`	`// Test f16 to f64 conversion`
`996`	`996`	`assert!(f64::from_f16(f16_val).is_some());`
`997`	`997`
`998`		`- // Test f16 to integer conversion (should fail)`
	`998`	`+ // Test PValue::F16(f16) to integer conversion (should fail)`
`999`	`999`	`assert!(i32::try_from(PValue::from(f16_val)).is_err());`
`1000`	`1000`	`assert!(u32::try_from(PValue::from(f16_val)).is_err());`
`1001`	`1001`	`}`