fix: also need to update ps_loc (#1792)

a10y · web-flow · commit 51bd26bad0a4 · 2025-01-02T21:30:09.000Z
Follow up to #1787, my unit test didn't fully capture the issue from the ticket. I've verified that after this change, I can successfully load the test file from the ticket using PyVortex.
diff --git a/vortex-file/src/read/builder/initial_read.rs b/vortex-file/src/read/builder/initial_read.rs
@@ -107,7 +107,7 @@ pub async fn read_initial_bytes<R: VortexReadAt>(
         )
     }
 
-    let ps_loc = eof_loc - ps_size;
+    let mut ps_loc = eof_loc - ps_size;
     let mut fb_postscript_byte_range = ps_loc..eof_loc;
 
     // we validate the footer here
@@ -149,6 +149,7 @@ pub async fn read_initial_bytes<R: VortexReadAt>(
         initial_read_offset = schema_offset;
         fb_postscript_byte_range.start += prefix_bytes;
         fb_postscript_byte_range.end += prefix_bytes;
+        ps_loc += prefix_bytes;
     }
 
     // validate the schema and layout

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ pub async fn read_initial_bytes<R: VortexReadAt>(`
`107`	`107`	`)`
`108`	`108`	`}`
`109`	`109`
`110`		`- let ps_loc = eof_loc - ps_size;`
	`110`	`+ let mut ps_loc = eof_loc - ps_size;`
`111`	`111`	`let mut fb_postscript_byte_range = ps_loc..eof_loc;`
`112`	`112`
`113`	`113`	`// we validate the footer here`
`@@ -149,6 +149,7 @@ pub async fn read_initial_bytes<R: VortexReadAt>(`
`149`	`149`	`initial_read_offset = schema_offset;`
`150`	`150`	`fb_postscript_byte_range.start += prefix_bytes;`
`151`	`151`	`fb_postscript_byte_range.end += prefix_bytes;`
	`152`	`+ ps_loc += prefix_bytes;`
`152`	`153`	`}`
`153`	`154`
`154`	`155`	`// validate the schema and layout`