unsafe

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

vortex-compute/src/take/slice/avx2.rs

@@ -72,7 +72,7 @@ pub unsafe fn take_avx2<V: NativePType, I: UnsignedPType>(
             let values = unsafe { std::mem::transmute::<&[V], &[$cast]>(buffer) };
 
             let result = exec_take::<$cast, $indices, AVX2Gather>(values, indices);
-            result.transmute::<V>()
+            unsafe { result.transmute::<V>() }
         }};
     }
 

vortex-compute/src/take/slice/portable.rs

@@ -5,21 +5,21 @@
 
 #![cfg(vortex_nightly)]
 
-use std::mem::MaybeUninit;
 use std::mem::size_of;
 use std::mem::transmute;
+use std::mem::MaybeUninit;
 use std::simd;
 use std::simd::num::SimdUint;
 
 use multiversion::multiversion;
 use vortex_buffer::Alignment;
 use vortex_buffer::Buffer;
 use vortex_buffer::BufferMut;
+use vortex_dtype::match_each_native_simd_ptype;
+use vortex_dtype::match_each_unsigned_integer_ptype;
 use vortex_dtype::NativePType;
 use vortex_dtype::PType;
 use vortex_dtype::UnsignedPType;
-use vortex_dtype::match_each_native_simd_ptype;
-use vortex_dtype::match_each_unsigned_integer_ptype;
 
 /// SIMD types larger than the SIMD register size are beneficial for
 /// performance as this leads to better instruction level parallelism.
@@ -40,7 +40,7 @@ pub fn take_portable<T: NativePType, I: UnsignedPType>(buffer: &[T], indices: &[
         // make.
         let u16_slice: &[u16] =
             unsafe { std::slice::from_raw_parts(buffer.as_ptr() as *const u16, buffer.len()) };
-        return take_with_indices(u16_slice, indices).transmute::<T>();
+        return unsafe { take_with_indices(u16_slice, indices).transmute::<T>() };
     }
 
     match_each_native_simd_ptype!(T::PTYPE, |TC| {