perf[ci]: cache correctly on runs-on in rustup rust

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

.github/actions/setup-rust/action.yml

@@ -15,6 +15,10 @@ inputs:
   targets:
     description: "optional targets override (e.g. wasm32-unknown-unknown)"
     required: false
+  skip-rust-cache:
+    description: "Skip Swatinem/rust-cache (useful when S3 sccache is already configured)"
+    required: false
+    default: "false"
 
 runs:
   using: "composite"
@@ -37,11 +41,15 @@ runs:
         targets: "${{inputs.targets || ''}}"
         components: "${{ inputs.components || 'clippy, rustfmt' }}"
 
+    # Skip rust-cache on runs-on runners that have S3 sccache configured.
+    # The rust-cache was ~10GB and took 3+ minutes to extract, while sccache
+    # S3 backend already provides efficient compile caching.
     - name: Rust Dependency Cache
+      if: ${{ inputs.skip-rust-cache != 'true' }}
       uses: Swatinem/rust-cache@v2
       with:
         save-if: ${{ github.ref_name == 'develop' }}
-        shared-key: "rust-cache-${{ runner.os }}-${{ runner.environment }}"  # To allow reuse across jobs
+        shared-key: "rust-cache-${{ runner.os }}-${{ runner.environment }}"
 
     - name: Rust Compile Cache
       uses: mozilla-actions/[email protected]

.github/workflows/ci.yml

@@ -138,6 +138,7 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
       - name: Docs
         run: |
           RUSTDOCFLAGS="-D warnings" cargo doc --no-deps
@@ -184,6 +185,7 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
       - name: Install wasm32 target
         if: ${{ matrix.config.target == 'wasm32-unknown-unknown' }}
         run: rustup target add wasm32-unknown-unknown
@@ -214,6 +216,7 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
       - uses: taiki-e/install-action@cargo-hack
       - uses: taiki-e/install-action@cargo-minimal-versions
       - run: cargo minimal-versions check --direct --workspace --ignore-private
@@ -237,6 +240,7 @@ jobs:
         with:
           toolchain: nightly
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
       - name: Rust Lint - Format
         run: cargo +nightly fmt --all --check
       - name: Rustc check
@@ -264,6 +268,7 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
       - name: Install cargo-hack
         uses: taiki-e/install-action@cargo-hack
       - name: Rust Lint - Clippy No Default Features
@@ -304,6 +309,7 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
       - name: Install grcov
         uses: taiki-e/install-action@grcov
       - name: Install nextest
@@ -379,6 +385,7 @@ jobs:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           toolchain: nightly
           components: "rust-src, rustfmt, clippy, llvm-tools-preview"
+          skip-rust-cache: true
       - name: Install build dependencies
         run: |
           sudo apt-get update
@@ -442,6 +449,7 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
       - name: Install nextest
         uses: taiki-e/install-action@v2
         with:
@@ -489,6 +497,7 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+          skip-rust-cache: true
 
       - name: Install Codspeed
         shell: bash