wip

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

bench-vortex/build.rs

@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![expect(clippy::unwrap_used)]
-#![expect(clippy::expect_used)]
+#![allow(clippy::unwrap_used)]
+#![allow(clippy::expect_used)]
 use std::env;
 use std::path::PathBuf;
 

bench-vortex/src/benchmark_trait.rs

@@ -50,7 +50,7 @@ pub trait Benchmark {
     fn generate_data(&self, target: &Target) -> Result<()>;
 
     /// Register tables with the engine context
-    #[allow(async_fn_in_trait)]
+    #[expect(async_fn_in_trait)]
     async fn register_tables(&self, engine_ctx: &EngineCtx, format: Format) -> Result<()>;
 
     /// Get the benchmark dataset identifier

bench-vortex/src/clickbench/clickbench_benchmark.rs

@@ -153,7 +153,6 @@ impl Benchmark for ClickBenchBenchmark {
         }
     }
 
-    #[allow(async_fn_in_trait)]
     async fn register_tables(&self, engine_ctx: &EngineCtx, format: Format) -> Result<()> {
         let dataset = self.dataset();
 

bench-vortex/src/lib.rs

@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![expect(clippy::unwrap_used)]
-#![expect(clippy::expect_used)]
+#![allow(clippy::unwrap_used)]
+#![allow(clippy::expect_used)]
 
 use std::clone::Clone;
 use std::fmt::Display;

bench-vortex/src/statpopgen/builder.rs

@@ -19,8 +19,7 @@ use vortex::utils::aliases::hash_set::HashSet;
 
 use super::vcf_conversion::*;
 
-#[allow(dead_code)]
-#[allow(non_snake_case)]
+#[expect(non_snake_case)]
 pub struct GnomADBuilder<'a> {
     /// The schema of the to-be-generated Parquet file.
     schema: SchemaRef,
@@ -231,7 +230,6 @@ impl InfoArrayBuilder {
 }
 
 impl<'a> GnomADBuilder<'a> {
-    #[allow(non_snake_case)]
     pub fn new(header: &'a Header, schema: SchemaRef) -> Self {
         let info_builder: HashMap<&'a str, InfoArrayBuilder> = header
             .infos()
@@ -264,7 +262,6 @@ impl<'a> GnomADBuilder<'a> {
         }
     }
 
-    #[expect(clippy::cognitive_complexity)]
     pub fn consume_record(&mut self, header: &Header, record: &mut Record) -> VortexResult<()> {
         self.CHROM_builder
             .append_value(record.reference_sequence_name());
@@ -352,7 +349,6 @@ impl<'a> GnomADBuilder<'a> {
         Ok(())
     }
 
-    #[expect(clippy::cognitive_complexity)]
     pub fn consume_info(&mut self, header: &Header, info: Info) -> VortexResult<()> {
         info.iter(header)
             .process_results(|iter| -> VortexResult<()> {
@@ -376,7 +372,6 @@ impl<'a> GnomADBuilder<'a> {
             })?
     }
 
-    #[expect(clippy::cognitive_complexity)]
     pub fn finish(mut self) -> Result<RecordBatch, ArrowError> {
         let len = self.CHROM_builder.len();
         assert_eq!(len, self.POS_builder.len());

bench-vortex/src/statpopgen/statpopgen_benchmark.rs

@@ -221,7 +221,6 @@ impl Benchmark for StatPopGenBenchmark {
         }
     }
 
-    #[allow(async_fn_in_trait)]
     async fn register_tables(&self, engine_ctx: &EngineCtx, format: Format) -> Result<()> {
         let dataset = self.dataset();
 

bench-vortex/src/tpch/tpch_benchmark.rs

@@ -137,7 +137,6 @@ impl Benchmark for TpcHBenchmark {
         }
     }
 
-    #[allow(async_fn_in_trait)]
     async fn register_tables(&self, engine_ctx: &EngineCtx, format: Format) -> Result<()> {
         let dataset = self.dataset();
 

encodings/alp/benches/alp_compress.rs

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![expect(clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use divan::Bencher;
 use rand::rngs::StdRng;

encodings/alp/src/alp/compute/compare.rs

@@ -190,15 +190,13 @@ mod tests {
             vec![1234; 1025]
         );
 
-        #[expect(clippy::excessive_precision)]
         let r_eq = alp_scalar_compare(&encoded, 1.234444_f32, Operator::Eq)
             .unwrap()
             .unwrap()
             .to_bool();
 
         assert!(r_eq.bit_buffer().iter().all(|v| !v));
 
-        #[expect(clippy::excessive_precision)]
         let r_neq = alp_scalar_compare(&encoded, 1.234444f32, Operator::NotEq)
             .unwrap()
             .unwrap()

encodings/alp/src/alp_rd/mod.rs

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![expect(clippy::cast_possible_truncation)]
+#![allow(clippy::cast_possible_truncation)]
 
 pub use array::*;
 use vortex_array::IntoArray;