wip

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-vector/src/binaryview/vector.rs

@@ -208,26 +208,7 @@ impl<T: BinaryViewType> BinaryViewVector<T> {
             return None;
         }
 
-        let view = &self.views[index];
-        if view.is_inlined() {
-            let view = view.as_inlined();
-            // SAFETY: validation that the string data contained in this vector is performed
-            //  at construction time, either in the constructor for safe construction, or by
-            //  the caller (when using the unchecked constructor).
-            Some(unsafe { T::from_bytes_unchecked(&view.data[..view.size as usize]) })
-        } else {
-            // Get a pointer into the buffer range
-            let view_ref = view.as_view();
-            let buffer = &self.buffers[view_ref.buffer_index as usize];
-
-            let start = view_ref.offset as usize;
-            let length = view_ref.size as usize;
-
-            // SAFETY: validation that the string data contained in this vector is performed
-            //  at construction time, either in the constructor for safe construction, or by
-            //  the caller (when using the unchecked constructor).
-            Some(unsafe { T::from_bytes_unchecked(&buffer.as_bytes()[start..start + length]) })
-        }
+        Some(unsafe { T::from_bytes_unchecked(self.get_ref_unchecked(index)) })
     }
 
     /// Get the `index` item from the vector as a [u8]