rob's suggestion

danking · danking · commit 5777dfbc10ec · 2025-11-05T14:22:24.000-05:00
Signed-off-by: Daniel King &lt;dan@spiraldb.com&gt;
diff --git a/vortex-array/src/serde.rs b/vortex-array/src/serde.rs
@@ -156,7 +156,7 @@ impl<'a> ArrayNodeFlatBuffer<'a> {
             }
         }
         let n_buffers_recursive = array.nbuffers_recursive();
-        if u16::try_from(n_buffers_recursive).is_err() {
+        if n_buffers_recursive > u16::MAX as usize {
             vortex_bail!(
                 "Array and all descendent arrays can have at most u16::MAX buffers: {}",
                 n_buffers_recursive

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ impl<'a> ArrayNodeFlatBuffer<'a> {`
`156`	`156`	`}`
`157`	`157`	`}`
`158`	`158`	`let n_buffers_recursive = array.nbuffers_recursive();`
`159`		`- if u16::try_from(n_buffers_recursive).is_err() {`
	`159`	`+ if n_buffers_recursive > u16::MAX as usize {`
`160`	`160`	`vortex_bail!(`
`161`	`161`	`"Array and all descendent arrays can have at most u16::MAX buffers: {}",`
`162`	`162`	`n_buffers_recursive`