Fix: Rename Array::null_count to invalid_count (#2244)

Author: robert3005

encodings/datetime-parts/src/stats.rs

@@ -8,7 +8,7 @@ use crate::{DateTimePartsArray, DateTimePartsEncoding};
 impl StatisticsVTable<DateTimePartsArray> for DateTimePartsEncoding {
     fn compute_statistics(&self, array: &DateTimePartsArray, stat: Stat) -> VortexResult<StatsSet> {
         let maybe_stat = match stat {
-            Stat::NullCount => Some(ScalarValue::from(array.null_count()?)),
+            Stat::NullCount => Some(ScalarValue::from(array.invalid_count()?)),
             Stat::IsConstant => Some(ScalarValue::from(
                 array.days().is_constant()
                     && array.seconds().is_constant()

vortex-array/src/validity.rs

@@ -32,7 +32,7 @@ impl Array {
     }
 
     /// Return the number of null elements in the array.
-    pub fn null_count(&self) -> VortexResult<usize> {
+    pub fn invalid_count(&self) -> VortexResult<usize> {
         if !self.dtype().is_nullable() {
             return Ok(0);
         }

vortex-layout/src/layouts/chunked/stats_table.rs

@@ -172,7 +172,7 @@ impl StatsAccumulator {
                 .map_err(|e| e.with_context(format!("Failed to finish stat builder for {stat}")))?;
 
             // We drop any all-null stats columns
-            if values.null_count()? == values.len() {
+            if values.invalid_count()? == values.len() {
                 continue;
             }