Skip to content

Commit 5f3f362

Browse files
authored
chore: Replace dependency on top level arrow create with individual modules now that pyarrow is a standalone crate (#3864)
Signed-off-by: Robert Kruszewski <[email protected]>
1 parent b1a8d1d commit 5f3f362

File tree

16 files changed

+61
-49
lines changed

16 files changed

+61
-49
lines changed

Cargo.lock

Lines changed: 10 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,16 @@ anyhow = "1.0.95"
5757
arbitrary = "1.3.2"
5858
arcref = "0.2.0"
5959
arrayref = "0.3.7"
60-
arrow = { version = "55.1", default-features = false }
61-
arrow-arith = "55.1"
62-
arrow-array = "55.1"
63-
arrow-buffer = "55.1"
64-
arrow-cast = "55.1"
65-
arrow-data = "55.1"
66-
arrow-ord = "55.1"
67-
arrow-schema = "55.1"
68-
arrow-select = "55.1"
69-
arrow-string = "55.1"
60+
arrow-arith = "55.2.0"
61+
arrow-array = "55.2.0"
62+
arrow-buffer = "55.2.0"
63+
arrow-cast = "55.2.0"
64+
arrow-data = "55.2.0"
65+
arrow-ord = "55.2.0"
66+
arrow-pyarrow = "55.2.0"
67+
arrow-schema = "55.2.0"
68+
arrow-select = "55.2.0"
69+
arrow-string = "55.2.0"
7070
async-stream = "0.3.6"
7171
async-trait = "0.1.88"
7272
bindgen = "0.72.0"
@@ -123,7 +123,7 @@ opentelemetry = "0.30.0"
123123
opentelemetry-otlp = "0.30.0"
124124
opentelemetry_sdk = "0.30.0"
125125
parking_lot = { version = "0.12.3", features = ["nightly"] }
126-
parquet = "55.1"
126+
parquet = "55.2.0"
127127
paste = "1.0.15"
128128
pco = "0.4.4"
129129
pin-project = "1.1.5"

vortex-duckdb/Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ crate-type = ["staticlib", "cdylib", "rlib"]
2121

2222
[dependencies]
2323
anyhow = { workspace = true }
24-
arrow = { workspace = true }
24+
arrow-array = { workspace = true }
25+
arrow-buffer = { workspace = true }
26+
arrow-schema = { workspace = true }
2527
bitvec = { workspace = true }
2628
crossbeam-queue = { workspace = true }
2729
glob = { workspace = true }

vortex-duckdb/src/convert/vector.rs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,16 @@
44
/// Copied of duckdb-rs (https://github.com/duckdb/duckdb-rs/blob/main/crates/duckdb/src/vtab/arrow.rs)
55
use std::sync::Arc;
66

7-
use arrow::array::{
8-
Array, BooleanArray, Date32Array, GenericBinaryBuilder, PrimitiveArray, StringArray,
9-
TimestampMicrosecondArray, TimestampNanosecondArray,
10-
};
11-
use arrow::buffer::{BooleanBuffer, NullBuffer};
12-
use arrow::datatypes::{
7+
use arrow_array::builder::GenericBinaryBuilder;
8+
use arrow_array::types::{
139
Float32Type, Float64Type, Int8Type, Int16Type, Int32Type, Int64Type, Time64MicrosecondType,
1410
UInt8Type, UInt16Type, UInt32Type, UInt64Type,
1511
};
12+
use arrow_array::{
13+
Array, BooleanArray, Date32Array, PrimitiveArray, StringArray, TimestampMicrosecondArray,
14+
TimestampNanosecondArray,
15+
};
16+
use arrow_buffer::buffer::{BooleanBuffer, NullBuffer};
1617
use bitvec::macros::internal::funty::Fundamental;
1718
use vortex::ArrayRef;
1819
use vortex::arrays::StructArray;

vortex-jni/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ rust-version = { workspace = true }
1717
categories = { workspace = true }
1818

1919
[dependencies]
20-
arrow = { workspace = true, features = ["ffi"] }
20+
arrow-array = { workspace = true, features = ["ffi"] }
21+
arrow-schema = { workspace = true }
2122
jni = "0.21.1"
2223
log = { workspace = true }
2324
object_store = { workspace = true, features = ["aws", "azure", "gcp"] }

vortex-jni/src/array.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
// SPDX-License-Identifier: Apache-2.0
22
// SPDX-FileCopyrightText: Copyright the Vortex contributors
33

4-
use arrow::datatypes::{DataType, FieldRef, Fields};
5-
use arrow::ffi::{FFI_ArrowArray, FFI_ArrowSchema};
4+
use arrow_array::ffi::{FFI_ArrowArray, FFI_ArrowSchema};
5+
use arrow_schema::{DataType, FieldRef, Fields};
66
use jni::JNIEnv;
77
use jni::objects::{JClass, JIntArray, JLongArray, JObject, JValue};
88
use jni::sys::{
@@ -86,7 +86,7 @@ pub extern "system" fn Java_dev_vortex_jni_NativeArrayMethods_exportToArrow<'loc
8686

8787
let arrow_array = array_ref.inner.clone().into_arrow(&viewless_arrow_type)?;
8888
let (ffi_array, ffi_schema) =
89-
arrow::ffi::to_ffi(&arrow_array.to_data()).map_err(VortexError::from)?;
89+
arrow_array::ffi::to_ffi(&arrow_array.to_data()).map_err(VortexError::from)?;
9090

9191
let ffi_schema_ptr = Box::into_raw(Box::new(ffi_schema));
9292
let ffi_array_ptr = Box::into_raw(Box::new(ffi_array));

vortex-python/Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ crate-type = ["rlib", "cdylib"]
2323
doctest = false # TODO(ngates): why?
2424

2525
[dependencies]
26-
arrow = { workspace = true, features = ["pyarrow"] }
26+
arrow-array = { workspace = true }
27+
arrow-data = { workspace = true }
28+
arrow-pyarrow = { workspace = true }
29+
arrow-schema = { workspace = true }
2730
futures = { workspace = true }
2831
itertools = { workspace = true }
2932
log = { workspace = true }

vortex-python/src/arrays/from_arrow.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// SPDX-License-Identifier: Apache-2.0
22
// SPDX-FileCopyrightText: Copyright the Vortex contributors
33

4-
use arrow::array::{ArrayData as ArrowArrayData, make_array};
5-
use arrow::datatypes::{DataType, Field};
6-
use arrow::ffi_stream::ArrowArrayStreamReader;
7-
use arrow::pyarrow::FromPyArrow;
8-
use arrow::record_batch::RecordBatchReader;
4+
use arrow_array::ffi_stream::ArrowArrayStreamReader;
5+
use arrow_array::{RecordBatchReader, make_array};
6+
use arrow_data::ArrayData as ArrowArrayData;
7+
use arrow_pyarrow::FromPyArrow;
8+
use arrow_schema::{DataType, Field};
99
use itertools::Itertools;
1010
use pyo3::exceptions::PyValueError;
1111
use pyo3::prelude::*;

vortex-python/src/arrays/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ pub(crate) mod from_arrow;
88
mod native;
99
pub(crate) mod py;
1010

11-
use arrow::array::{Array as ArrowArray, ArrayRef as ArrowArrayRef};
12-
use arrow::pyarrow::ToPyArrow;
11+
use arrow_array::{Array as ArrowArray, ArrayRef as ArrowArrayRef};
12+
use arrow_pyarrow::ToPyArrow;
1313
use pyo3::exceptions::{PyTypeError, PyValueError};
1414
use pyo3::prelude::*;
1515
use pyo3::types::{PyDict, PyList};

vortex-python/src/dataset.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33

44
use std::sync::Arc;
55

6-
use arrow::array::RecordBatchReader;
7-
use arrow::datatypes::SchemaRef;
8-
use arrow::pyarrow::{IntoPyArrow, ToPyArrow};
6+
use arrow_array::RecordBatchReader;
7+
use arrow_pyarrow::{IntoPyArrow, ToPyArrow};
8+
use arrow_schema::SchemaRef;
99
use pyo3::exceptions::PyTypeError;
1010
use pyo3::prelude::*;
1111
use pyo3::types::PyString;

0 commit comments

Comments
 (0)