Skip to content

Commit 6e73e49

Browse files
committed
remove unnecessary assertion in ListView
Signed-off-by: Andrew Duffy <[email protected]>
1 parent fd8f215 commit 6e73e49

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

vortex-array/src/array/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ use vortex_scalar::Scalar;
2121

2222
use crate::arrays::{
2323
BoolEncoding, ConstantVTable, DecimalEncoding, ExtensionEncoding, FixedSizeListEncoding,
24-
ListEncoding, ListViewEncoding, NullEncoding, PrimitiveEncoding, StructEncoding,
25-
VarBinEncoding, VarBinViewEncoding,
24+
ListViewEncoding, NullEncoding, PrimitiveEncoding, StructEncoding, VarBinEncoding,
25+
VarBinViewEncoding,
2626
};
2727
use crate::builders::ArrayBuilder;
2828
use crate::compute::{ComputeFn, Cost, InvocationArgs, IsConstantOpts, Output, is_constant_opts};

vortex-array/src/arrays/listview/array.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -221,17 +221,6 @@ impl ListViewArray {
221221
// Check that the size type can fit within the offset type to prevent overflows.
222222
let size_ptype = sizes.dtype().as_ptype();
223223
let offset_ptype = offsets.dtype().as_ptype();
224-
let size_max = sizes.dtype().as_ptype().max_value_as_u64();
225-
let offset_max = offsets.dtype().as_ptype().max_value_as_u64();
226-
227-
vortex_ensure!(
228-
size_max <= offset_max,
229-
"size type {:?} (max {}) must fit within offset type {:?} (max {})",
230-
size_ptype,
231-
size_max,
232-
offset_ptype,
233-
offset_max
234-
);
235224

236225
// If a validity array is present, it must be the same length as the `ListViewArray`.
237226
if let Some(validity_len) = validity.maybe_len() {

0 commit comments

Comments
 (0)