disable SIMD take

connortsui20 · connortsui20 · commit 769a380d70ad · 2025-12-09T15:59:53.000-05:00
Signed-off-by: Connor Tsui &lt;connor.tsui20@gmail.com&gt;
diff --git a/vortex-compute/src/take/slice/mod.rs b/vortex-compute/src/take/slice/mod.rs
@@ -16,6 +16,9 @@ impl<T: Copy, I: UnsignedPType> Take<[I]> for &[T] {
     type Output = Buffer<T>;
 
     fn take(self, indices: &[I]) -> Buffer<T> {
+        // TODO(connor): Make the SIMD implementations bound by `Copy` instead of `NativePType`.
+        /*
+
         #[cfg(vortex_nightly)]
         {
             return portable::take_portable(self, indices);
@@ -29,6 +32,8 @@ impl<T: Copy, I: UnsignedPType> Take<[I]> for &[T] {
             }
         }
 
+        */
+
         #[allow(unreachable_code, reason = "`vortex_nightly` path returns early")]
         take_scalar(self, indices)
     }

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,9 @@ impl<T: Copy, I: UnsignedPType> Take<[I]> for &[T] {`
`16`	`16`	`type Output = Buffer<T>;`
`17`	`17`
`18`	`18`	`fn take(self, indices: &[I]) -> Buffer<T> {`
	`19`	+ // TODO(connor): Make the SIMD implementations bound by `Copy` instead of `NativePType`.
	`20`	`+ /*`
	`21`	`+`
`19`	`22`	`#[cfg(vortex_nightly)]`
`20`	`23`	`{`
`21`	`24`	`return portable::take_portable(self, indices);`
`@@ -29,6 +32,8 @@ impl<T: Copy, I: UnsignedPType> Take<[I]> for &[T] {`
`29`	`32`	`}`
`30`	`33`	`}`
`31`	`34`
	`35`	`+ */`
	`36`	`+`
`32`	`37`	#[allow(unreachable_code, reason = "`vortex_nightly` path returns early")]
`33`	`38`	`take_scalar(self, indices)`
`34`	`39`	`}`