feat: teach PrimitiveArrayTrait iterate_primitive_array! and RowMask from_index_array (#1241)

This touches a dumb number of files and regardless of how the
`with_indices` implementation shakes out, I think we'll need it.

Author: danking

encodings/alp/src/alp/array.rs

@@ -105,13 +105,6 @@ impl ALPArray {
         })
     }
 
-    #[inline]
-    pub fn ptype(&self) -> PType {
-        self.dtype()
-            .try_into()
-            .vortex_expect("Failed to convert DType to PType")
-    }
-
     #[inline]
     fn encoded_dtype(&self) -> DType {
         match self.dtype() {

encodings/alp/src/alp/compress.rs

@@ -1,5 +1,6 @@
 use vortex_array::array::{PrimitiveArray, Sparse, SparseArray};
 use vortex_array::validity::Validity;
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::{Array, ArrayDType, ArrayDef, IntoArray, IntoArrayVariant};
 use vortex_dtype::{NativePType, PType};
 use vortex_error::{vortex_bail, VortexExpect as _, VortexResult};

encodings/alp/src/alp/compute.rs

@@ -5,6 +5,7 @@ use vortex_array::compute::{
 };
 use vortex_array::stats::{ArrayStatistics, Stat};
 use vortex_array::validity::Validity;
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::{Array, ArrayDType, IntoArray};
 use vortex_error::{VortexExpect, VortexResult};
 use vortex_scalar::{PValue, Scalar};

encodings/alp/src/alp_rd/mod.rs

@@ -1,5 +1,6 @@
 pub use array::*;
 use vortex_array::validity::Validity;
+use vortex_array::variants::PrimitiveArrayTrait;
 
 mod array;
 mod compute;

encodings/bytebool/src/compute.rs

@@ -2,6 +2,7 @@ use num_traits::AsPrimitive;
 use vortex_array::compute::unary::{FillForwardFn, ScalarAtFn};
 use vortex_array::compute::{ArrayCompute, SliceFn, TakeFn};
 use vortex_array::validity::{ArrayValidity, Validity};
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::{Array, ArrayDType, IntoArray};
 use vortex_dtype::{match_each_integer_ptype, Nullability};
 use vortex_error::{vortex_err, VortexResult};

encodings/dict/src/array.rs

@@ -9,6 +9,7 @@ use vortex_array::compute::unary::scalar_at;
 use vortex_array::encoding::ids;
 use vortex_array::stats::StatsSet;
 use vortex_array::validity::{ArrayValidity, LogicalValidity};
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::{
     impl_encoding, Array, ArrayDType, ArrayTrait, Canonical, IntoArray, IntoArrayVariant,
     IntoCanonical,

encodings/dict/src/compress.rs

@@ -9,6 +9,7 @@ use vortex_array::array::{
     ConstantArray, PrimitiveArray, SparseArray, VarBinArray, VarBinViewArray,
 };
 use vortex_array::validity::Validity;
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::{ArrayDType, IntoArray, IntoCanonical};
 use vortex_dtype::{match_each_native_ptype, DType, NativePType, ToBytes};
 use vortex_error::{VortexExpect as _, VortexUnwrap};

encodings/fastlanes/src/bitpacking/compress.rs

@@ -3,6 +3,7 @@ use fastlanes::BitPacking;
 use vortex_array::array::{PrimitiveArray, Sparse, SparseArray};
 use vortex_array::stats::ArrayStatistics;
 use vortex_array::validity::{ArrayValidity, Validity};
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::{Array, ArrayDType, ArrayDef, IntoArray, IntoArrayVariant};
 use vortex_buffer::Buffer;
 use vortex_dtype::{

encodings/fastlanes/src/bitpacking/compute/search_sorted.rs

@@ -10,6 +10,7 @@ use vortex_array::compute::{
     search_sorted_u64, IndexOrd, Len, SearchResult, SearchSorted, SearchSortedFn, SearchSortedSide,
 };
 use vortex_array::validity::Validity;
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::ArrayDType;
 use vortex_dtype::{match_each_unsigned_integer_ptype, NativePType};
 use vortex_error::{VortexError, VortexExpect as _, VortexResult};

encodings/fastlanes/src/bitpacking/compute/slice.rs

@@ -2,6 +2,7 @@ use std::cmp::max;
 
 use vortex_array::array::SparseArray;
 use vortex_array::compute::{slice, SliceFn};
+use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::{Array, IntoArray};
 use vortex_error::{VortexExpect, VortexResult};