Skip to content

Commit 7ccfaa5

Browse files
authored
Fix semver check in CI (#6026)
1. Hide `vortex-cuda` which is not released yet (Do we want to release it in the next release?) 2. Rename the `test-harness` feature into `_test-harness`, which makes `cargo-semver-check` to ignore it. Signed-off-by: Adam Gutglick <[email protected]>
1 parent 0df286c commit 7ccfaa5

File tree

33 files changed

+51
-49
lines changed

33 files changed

+51
-49
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,8 @@ jobs:
368368
369369
- name: Check semver
370370
uses: obi1kenobi/cargo-semver-checks-action@v2
371+
with:
372+
exclude: vortex-cuda
371373

372374
rust-coverage:
373375
name: "Rust tests (coverage) (${{ matrix.suite }})"
@@ -604,10 +606,10 @@ jobs:
604606
matrix:
605607
include:
606608
- { shard: 1, name: "Core foundation", packages: "vortex-buffer vortex-dtype vortex-error" }
607-
- { shard: 2, name: "Array types", packages: "vortex-array vortex-scalar vortex-vector", features: "--features test-harness" }
609+
- { shard: 2, name: "Array types", packages: "vortex-array vortex-scalar vortex-vector", features: "--features _test-harness" }
608610
- { shard: 3, name: "Main library", packages: "vortex vortex-compute" }
609611
- { shard: 4, name: "Encodings 1", packages: "vortex-alp vortex-bytebool vortex-datetime-parts" }
610-
- { shard: 5, name: "Encodings 2", packages: "vortex-decimal-byte-parts vortex-fastlanes vortex-fsst", features: "--features test-harness" }
612+
- { shard: 5, name: "Encodings 2", packages: "vortex-decimal-byte-parts vortex-fastlanes vortex-fsst", features: "--features _test-harness" }
611613
- { shard: 6, name: "Encodings 3", packages: "vortex-pco vortex-runend vortex-sequence" }
612614
- { shard: 7, name: "Encodings 4", packages: "vortex-sparse vortex-zigzag vortex-zstd" }
613615
- { shard: 8, name: "Storage formats", packages: "vortex-flatbuffers vortex-proto vortex-btrblocks" }

encodings/alp/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ vortex-vector = { workspace = true }
3636
divan = { workspace = true }
3737
rand = { workspace = true }
3838
rstest = { workspace = true }
39-
vortex-array = { workspace = true, features = ["test-harness"] }
39+
vortex-array = { workspace = true, features = ["_test-harness"] }
4040

4141
[[bench]]
4242
name = "alp_compress"

encodings/bytebool/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ vortex-scalar = { workspace = true }
2727

2828
[dev-dependencies]
2929
rstest = { workspace = true }
30-
vortex-array = { workspace = true, features = ["test-harness"] }
30+
vortex-array = { workspace = true, features = ["_test-harness"] }

encodings/datetime-parts/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ vortex-scalar = { workspace = true }
2828

2929
[dev-dependencies]
3030
rstest = { workspace = true }
31-
vortex-array = { workspace = true, features = ["test-harness"] }
31+
vortex-array = { workspace = true, features = ["_test-harness"] }

encodings/decimal-byte-parts/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ vortex-scalar = { workspace = true }
2828

2929
[dev-dependencies]
3030
rstest = { workspace = true }
31-
vortex-array = { path = "../../vortex-array", features = ["test-harness"] }
31+
vortex-array = { path = "../../vortex-array", features = ["_test-harness"] }

encodings/fastlanes/Cargo.toml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ itertools = { workspace = true }
4040
rand = { workspace = true }
4141
rstest = { workspace = true }
4242
vortex-alp = { path = "../alp" }
43-
vortex-array = { workspace = true, features = ["test-harness"] }
44-
vortex-fastlanes = { path = ".", features = ["test-harness"] }
43+
vortex-array = { workspace = true, features = ["_test-harness"] }
44+
vortex-fastlanes = { path = ".", features = ["_test-harness"] }
4545

4646
[features]
47-
test-harness = ["dep:rand"]
47+
_test-harness = ["dep:rand"]
4848

4949
[[bench]]
5050
name = "bitpacking_take"
@@ -57,9 +57,9 @@ harness = false
5757
[[bench]]
5858
name = "canonicalize_bench"
5959
harness = false
60-
required-features = ["test-harness"]
60+
required-features = ["_test-harness"]
6161

6262
[[bench]]
6363
name = "compute_between"
6464
harness = false
65-
required-features = ["test-harness"]
65+
required-features = ["_test-harness"]

encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ fn bytes_per_exception(ptype: PType) -> usize {
365365
ptype.byte_width() + 4
366366
}
367367

368-
#[cfg(feature = "test-harness")]
368+
#[cfg(feature = "_test-harness")]
369369
pub mod test_harness {
370370
use rand::Rng as _;
371371
use rand::rngs::StdRng;

encodings/fsst/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ vortex-scalar = { workspace = true }
3030
vortex-vector = { workspace = true }
3131

3232
[features]
33-
test-harness = ["dep:rand", "vortex-array/test-harness"]
33+
_test-harness = ["dep:rand", "vortex-array/_test-harness"]
3434

3535
[dev-dependencies]
3636
divan = { workspace = true }
3737
rand = { workspace = true }
3838
rstest = { workspace = true }
39-
vortex-array = { workspace = true, features = ["test-harness"] }
39+
vortex-array = { workspace = true, features = ["_test-harness"] }
4040

4141
[[bench]]
4242
name = "fsst_compress"
@@ -45,7 +45,7 @@ harness = false
4545
[[bench]]
4646
name = "chunked_dict_fsst_builder"
4747
harness = false
48-
required-features = ["test-harness"]
48+
required-features = ["_test-harness"]
4949

5050
[package.metadata.cargo-machete]
5151
ignored = ["fsst-rs"]

encodings/fsst/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ mod compress;
1717
mod compute;
1818
mod kernel;
1919
mod ops;
20-
#[cfg(feature = "test-harness")]
20+
#[cfg(feature = "_test-harness")]
2121
pub mod test_utils;
2222
#[cfg(test)]
2323
mod tests;

encodings/pco/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ divan = { workspace = true }
3131
mimalloc = { workspace = true }
3232
rand = { workspace = true }
3333
rstest = { workspace = true }
34-
vortex-array = { workspace = true, features = ["test-harness"] }
34+
vortex-array = { workspace = true, features = ["_test-harness"] }
3535

3636
[[bench]]
3737
name = "pco"

0 commit comments

Comments
 (0)