fix tests too

Signed-off-by: Daniel King <[email protected]>

Author: danking

vortex-dtype/src/arrow.rs

@@ -337,7 +337,7 @@ mod test {
     #[test]
     #[should_panic]
     fn test_dtype_conversion_panics() {
-        let _ = DType::Extension(Arc::new(ExtDType::new(
+        let _unused = DType::Extension(Arc::new(ExtDType::new(
             ExtID::from("my-fake-ext-dtype"),
             Arc::new(DType::Utf8(Nullability::NonNullable)),
             None,
@@ -380,6 +380,6 @@ mod test {
     #[should_panic]
     fn test_schema_conversion_panics(the_struct: StructFields) {
         let schema_null = DType::Struct(the_struct, Nullability::Nullable);
-        let _ = schema_null.to_arrow_schema().unwrap();
+        let _unused = schema_null.to_arrow_schema().unwrap();
     }
 }

vortex-io/src/io_buf.rs

@@ -446,14 +446,14 @@ mod tests {
     fn test_owned_slice_invalid_range() {
         let data = vec![1, 2, 3];
         #[allow(clippy::reversed_empty_ranges)]
-        let _ = data.slice_owned(5..3); // start > end
+        let _unused = data.slice_owned(5..3); // start > end
     }
 
     #[test]
     #[should_panic(expected = "exceeds buffer length")]
     fn test_owned_slice_out_of_bounds() {
         let data = vec![1, 2, 3];
-        let _ = data.slice_owned(1..10); // end > len
+        let _unused = data.slice_owned(1..10); // end > len
     }
 
     #[test]
@@ -467,7 +467,7 @@ mod tests {
     #[should_panic(expected = "exceeds buffer length")]
     fn test_owned_slice_start_out_of_bounds() {
         let data = vec![1, 2, 3];
-        let _ = data.slice_owned(10..11); // start > len
+        let _unused = data.slice_owned(10..11); // start > len
     }
 
     // Buffer overflow protection tests

vortex-io/src/limit.rs

@@ -259,7 +259,7 @@ mod tests {
         assert!(result.is_err());
 
         // After consuming, should be able to push again
-        let _ = stream.next().await;
+        let _unused = stream.next().await;
         assert_eq!(stream.bytes_available(), 10);
 
         let result = stream.try_push(Box::pin(async { vec![1u8; 5] }), 5);

vortex-io/src/runtime/tests.rs

@@ -290,9 +290,9 @@ async fn test_custom_io_source() {
     let file_read = handle.open_read(source, Default::default()).unwrap();
 
     // Perform several reads
-    let _ = file_read.read_at(0, 5, Alignment::new(1)).await.unwrap();
-    let _ = file_read.read_at(5, 5, Alignment::new(1)).await.unwrap();
-    let _ = file_read.read_at(10, 5, Alignment::new(1)).await.unwrap();
+    let _unused = file_read.read_at(0, 5, Alignment::new(1)).await.unwrap();
+    let _unused = file_read.read_at(5, 5, Alignment::new(1)).await.unwrap();
+    let _unused = file_read.read_at(10, 5, Alignment::new(1)).await.unwrap();
 
     // Check that our custom IoSource was called 3 times
     assert_eq!(read_count.load(Ordering::SeqCst), 3);

vortex-mask/src/bitops.rs

@@ -181,7 +181,7 @@ mod tests {
     fn test_bitand_different_lengths() {
         let mask1 = Mask::new_true(5);
         let mask2 = Mask::new_true(3);
-        let _ = &mask1 & &mask2;
+        let _unused = &mask1 & &mask2;
     }
 
     #[test]

vortex-mask/src/intersect_by_rank.rs

@@ -149,7 +149,7 @@ mod test {
     fn test_intersect_by_rank_wrong_length() {
         let m1 = Mask::from_indices(10, vec![2, 5, 7]); // 3 true values
         let m2 = Mask::new_true(5); // 5 true values - doesn't match
-        let _ = m1.intersect_by_rank(&m2);
+        let _unused = m1.intersect_by_rank(&m2);
     }
 
     #[rstest]

vortex-mask/src/mask_mut.rs

@@ -498,7 +498,7 @@ mod tests {
     #[should_panic(expected = "split_off index out of bounds")]
     fn test_split_off_out_of_bounds() {
         let mut mask = MaskMut::new_true(10);
-        let _ = mask.split_off(11);
+        let _unused = mask.split_off(11);
     }
 
     #[test]

vortex-mask/src/tests.rs

@@ -141,7 +141,7 @@ fn test_mask_slice() {
 #[should_panic]
 fn test_mask_slice_out_of_bounds() {
     let mask = Mask::new_true(5);
-    let _ = mask.slice(3..8); // offset + length > len
+    let _unused = mask.slice(3..8); // offset + length > len
 }
 
 // Limit operations
@@ -374,7 +374,7 @@ fn test_mask_valid_counts_for_indices() {
 fn test_mask_valid_counts_for_indices_error() {
     let mask = Mask::from_buffer(BitBuffer::from_iter([true, false, true]));
     let indices = vec![0, 2, 5]; // 5 is out of bounds
-    let _ = mask.valid_counts_for_indices(&indices);
+    let _unused = mask.valid_counts_for_indices(&indices);
 }
 
 // FromIterator tests
@@ -441,37 +441,37 @@ fn test_mask_from_iter_with_empty_masks() {
 #[test]
 #[should_panic]
 fn test_mask_from_indices_unsorted() {
-    let _ = Mask::from_indices(5, vec![2, 0, 3]); // Not sorted
+    let _unused = Mask::from_indices(5, vec![2, 0, 3]); // Not sorted
 }
 
 #[test]
 #[should_panic]
 fn test_mask_from_indices_out_of_bounds() {
-    let _ = Mask::from_indices(5, vec![0, 2, 5]); // 5 is out of bounds
+    let _unused = Mask::from_indices(5, vec![0, 2, 5]); // 5 is out of bounds
 }
 
 #[test]
 #[should_panic]
 fn test_mask_from_slices_invalid_range() {
-    let _ = Mask::from_slices(5, vec![(2, 2)]); // Invalid range where start == end
+    let _unused = Mask::from_slices(5, vec![(2, 2)]); // Invalid range where start == end
 }
 
 #[test]
 #[should_panic]
 fn test_mask_from_slices_out_of_bounds() {
-    let _ = Mask::from_slices(5, vec![(0, 6)]); // end > len
+    let _unused = Mask::from_slices(5, vec![(0, 6)]); // end > len
 }
 
 #[test]
 #[should_panic]
 fn test_mask_from_slices_unsorted() {
-    let _ = Mask::from_slices(5, vec![(2, 3), (0, 1)]); // Not sorted
+    let _unused = Mask::from_slices(5, vec![(2, 3), (0, 1)]); // Not sorted
 }
 
 #[test]
 #[should_panic]
 fn test_mask_from_slices_overlapping() {
-    let _ = Mask::from_slices(5, vec![(0, 3), (2, 4)]); // Overlapping ranges
+    let _unused = Mask::from_slices(5, vec![(0, 3), (2, 4)]); // Overlapping ranges
 }
 
 // Threshold iterator tests