Faster pipelines

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

encodings/fastlanes/src/bitpacking/array/bitpack_pipeline.rs

@@ -1,18 +1,18 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+use std::mem::{transmute, transmute_copy};
+
 use fastlanes::{BitPacking, FastLanes};
 use static_assertions::const_assert_eq;
-use std::mem::{transmute, transmute_copy};
 use vortex_array::pipeline::bit_view::BitView;
-use vortex_array::pipeline::{BindContext, Kernel, KernelCtx, PipelineInputs, PipelinedNode, N};
+use vortex_array::pipeline::{BindContext, Kernel, KernelCtx, N, PipelineInputs, PipelinedNode};
 use vortex_buffer::Buffer;
-use vortex_dtype::{match_each_integer_ptype, PTypeDowncastExt, PhysicalPType};
+use vortex_dtype::{PTypeDowncastExt, PhysicalPType, match_each_integer_ptype};
 use vortex_error::VortexResult;
 use vortex_mask::MaskMut;
 use vortex_vector::primitive::PVectorMut;
-use vortex_vector::VectorMut;
-use vortex_vector::VectorMutOps;
+use vortex_vector::{VectorMut, VectorMutOps};
 
 use crate::BitPackedArray;
 
@@ -200,12 +200,13 @@ impl<BP: PhysicalPType<Physical: BitPacking>> Kernel for AlignedBitPackedKernel<
 
 #[cfg(test)]
 mod tests {
-    use crate::BitPackedArray;
     use vortex_array::arrays::PrimitiveArray;
     use vortex_dtype::PTypeDowncast;
     use vortex_mask::Mask;
     use vortex_vector::VectorOps;
 
+    use crate::BitPackedArray;
+
     #[test]
     fn test_bitpack_pipeline_basic() {
         // Create exactly 1024 elements (0 to 1023).

vortex-array/src/pipeline/driver/allocation.rs

@@ -6,9 +6,9 @@
 use vortex_error::{VortexExpect, VortexResult};
 use vortex_vector::VectorMut;
 
-use crate::pipeline::driver::{Node, NodeId};
-use crate::pipeline::{VectorId, N};
 use crate::Array;
+use crate::pipeline::driver::{Node, NodeId};
+use crate::pipeline::{N, VectorId};
 
 #[derive(Debug)]
 pub struct VectorAllocation {

vortex-array/src/pipeline/driver/input.rs

@@ -73,7 +73,7 @@ impl Kernel for InputKernel {
 
 #[cfg(test)]
 mod test {
-    use vortex_buffer::{bitbuffer, buffer, BitBuffer};
+    use vortex_buffer::{BitBuffer, bitbuffer, buffer};
     use vortex_dtype::PTypeDowncastExt;
     use vortex_mask::Mask;
 

vortex-array/src/pipeline/driver/mod.rs

@@ -11,16 +11,16 @@ use std::hash::{BuildHasher, Hash, Hasher};
 
 use itertools::Itertools;
 use vortex_dtype::DType;
-use vortex_error::{vortex_ensure, VortexResult};
+use vortex_error::{VortexResult, vortex_ensure};
 use vortex_mask::Mask;
 use vortex_utils::aliases::hash_map::{HashMap, RandomState};
 use vortex_vector::{Vector, VectorMut, VectorMutOps};
 
 use crate::pipeline::bit_view::{BitView, BitViewExt};
-use crate::pipeline::driver::allocation::{allocate_vectors, OutputTarget};
+use crate::pipeline::driver::allocation::{OutputTarget, allocate_vectors};
 use crate::pipeline::driver::bind::bind_kernels;
 use crate::pipeline::driver::toposort::topological_sort;
-use crate::pipeline::{Kernel, KernelCtx, PipelineInputs, N};
+use crate::pipeline::{Kernel, KernelCtx, N, PipelineInputs};
 use crate::{Array, ArrayEq, ArrayHash, ArrayOperator, ArrayRef, ArrayVisitor, Precision};
 
 /// A pipeline driver takes a Vortex array and executes it into a canonical vector.

vortex-array/src/pipeline/filter/buffer.rs

@@ -1,10 +1,11 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-use crate::pipeline::bit_view::BitView;
-use crate::pipeline::N;
 use vortex_compute::filter::Filter;
 
+use crate::pipeline::N;
+use crate::pipeline::bit_view::BitView;
+
 impl<'a, T: Copy> Filter<BitView<'a>> for &'a mut [T] {
     type Output = ();
 

vortex-array/src/pipeline/filter/mod.rs

@@ -3,12 +3,13 @@
 
 mod buffer;
 
-use crate::pipeline::bit_view::BitView;
 use vortex_compute::filter::Filter;
 use vortex_dtype::NativePType;
 use vortex_mask::MaskMut;
 use vortex_vector::primitive::{PVectorMut, PrimitiveVectorMut};
-use vortex_vector::{match_each_pvector_mut, VectorMut, VectorMutOps};
+use vortex_vector::{VectorMut, match_each_pvector_mut};
+
+use crate::pipeline::bit_view::BitView;
 
 impl Filter<BitView<'_>> for &mut VectorMut {
     type Output = ();

vortex-buffer/src/bit/buf.rs

@@ -5,10 +5,10 @@ use std::ops::{BitAnd, BitOr, BitXor, Not, RangeBounds};
 
 use crate::bit::ops::{bitwise_binary_op, bitwise_unary_op};
 use crate::bit::{
-    get_bit_unchecked, BitChunks, BitIndexIterator, BitIterator, BitSliceIterator,
-    UnalignedBitChunk,
+    BitChunks, BitIndexIterator, BitIterator, BitSliceIterator, UnalignedBitChunk,
+    get_bit_unchecked,
 };
-use crate::{buffer, Alignment, BitBufferMut, Buffer, BufferMut, ByteBuffer};
+use crate::{Alignment, BitBufferMut, Buffer, BufferMut, ByteBuffer, buffer};
 
 /// An immutable bitset stored as a packed byte buffer.
 #[derive(Debug, Clone, Eq)]
@@ -495,7 +495,7 @@ mod tests {
     use rstest::rstest;
 
     use crate::bit::BitBuffer;
-    use crate::{buffer, ByteBuffer};
+    use crate::{ByteBuffer, buffer};
 
     #[test]
     fn test_bool() {

vortex-buffer/src/buffer.rs

@@ -10,7 +10,7 @@ use std::marker::PhantomData;
 use std::ops::{Deref, RangeBounds};
 
 use bytes::{Buf, Bytes};
-use vortex_error::{vortex_panic, VortexExpect};
+use vortex_error::{VortexExpect, vortex_panic};
 
 use crate::debug::TruncatedDebug;
 use crate::trusted_len::TrustedLen;
@@ -657,7 +657,7 @@ impl<T> From<BufferMut<T>> for Buffer<T> {
 mod test {
     use bytes::Buf;
 
-    use crate::{buffer, Alignment, Buffer, ByteBuffer};
+    use crate::{Alignment, Buffer, ByteBuffer, buffer};
 
     #[test]
     fn align() {

vortex-mask/src/lib.rs

@@ -20,8 +20,8 @@ use std::sync::{Arc, OnceLock};
 
 use itertools::Itertools;
 pub use mask_mut::*;
-use vortex_buffer::{set_bit_unchecked, BitBuffer, BitBufferMut};
-use vortex_error::{vortex_panic, VortexResult};
+use vortex_buffer::{BitBuffer, BitBufferMut, set_bit_unchecked};
+use vortex_error::{VortexResult, vortex_panic};
 
 /// Represents a set of values that are all included, all excluded, or some mixture of both.
 pub enum AllOr<T> {

vortex-vector/src/binaryview/vector.rs

@@ -8,11 +8,11 @@ use std::ops::RangeBounds;
 use std::sync::Arc;
 
 use vortex_buffer::{Alignment, Buffer, ByteBuffer};
-use vortex_error::{vortex_ensure, VortexExpect, VortexResult};
+use vortex_error::{VortexExpect, VortexResult, vortex_ensure};
 use vortex_mask::Mask;
 
 use crate::binaryview::vector_mut::BinaryViewVectorMut;
-use crate::binaryview::view::{validate_views, BinaryView};
+use crate::binaryview::view::{BinaryView, validate_views};
 use crate::binaryview::{BinaryViewScalar, BinaryViewType};
 use crate::{Scalar, VectorOps};
 
@@ -198,11 +198,6 @@ impl<T: BinaryViewType> VectorOps for BinaryViewVector<T> {
         self.views.len()
     }
 
-    fn clear(&mut self) {
-        self.views.clear();
-        self.validity.clear();
-    }
-
     fn validity(&self) -> &Mask {
         &self.validity
     }
@@ -280,7 +275,7 @@ impl<T: BinaryViewType> VectorOps for BinaryViewVector<T> {
 mod tests {
     use std::sync::Arc;
 
-    use vortex_buffer::{buffer, ByteBuffer};
+    use vortex_buffer::{ByteBuffer, buffer};
     use vortex_mask::Mask;
 
     use crate::binaryview::view::BinaryView;