DuckDB renovate (#3832)

Renovate is notoriously hard to actually run and test locally... so I've
downgraded the DuckDB version just to see if it will be upgraded again!

We should think how we want this work r.e. our other repo,
vortex-duckdb.

---------

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

bench-vortex/build.rs

@@ -22,9 +22,8 @@ use std::path::PathBuf;
 /// static lib is not self-contained. This means that it includes symbols which
 /// are not defined as part of the static library.
 fn main() {
-    const DUCKDB_VERSION: &str = "v1.3.2";
     let manifest_dir = PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap());
     let target_dir = manifest_dir.parent().unwrap().join("target");
-    let lib_path = target_dir.join(format!("duckdb-lib-{DUCKDB_VERSION}"));
+    let lib_path = target_dir.join("duckdb-lib");
     println!("cargo:rustc-link-arg=-Wl,-rpath,{}", lib_path.display());
 }

renovate.json

@@ -21,10 +21,16 @@
   "patch": {
     "groupName": "all patch updates"
   },
-  "labels": ["chore"],
+  "labels": [
+    "chore"
+  ],
   "packageRules": [
     {
-      "matchUpdateTypes": ["major", "minor", "patch"],
+      "matchUpdateTypes": [
+        "major",
+        "minor",
+        "patch"
+      ],
       "groupName": "datafusion and friends",
       "matchPackageNames": [
         "arrow{/,}**",
@@ -35,15 +41,37 @@
     },
     {
       "groupName": "flatbuffers",
-      "matchPackageNames": ["flatbuffers{/,}**", "flexbuffers{/,}**"]
+      "matchPackageNames": [
+        "flatbuffers{/,}**",
+        "flexbuffers{/,}**"
+      ]
     },
     {
       "groupName": "futures",
-      "matchPackageNames": ["futures{/,}**"]
+      "matchPackageNames": [
+        "futures{/,}**"
+      ]
     },
     {
       "groupName": "tonic",
-      "matchPackageNames": ["tonic{/,}**"]
+      "matchPackageNames": [
+        "tonic{/,}**"
+      ]
+    }
+  ],
+  "regexManagers": [
+    {
+      "description": "Update DuckDB version in vortex-duckdb/build.rs",
+      "customType": "regex",
+      "fileMatch": [
+        "vortex-duckdb/build\\.rs"
+      ],
+      "matchStrings": [
+        "const DUCKDB_VERSION: &str = \"(?<currentValue>[0-9]+\\.[0-9]+\\.[0-9]+)\";"
+      ],
+      "depNameTemplate": "duckdb/duckdb",
+      "datasourceTemplate": "github-releases",
+      "extractVersionTemplate": "^v?(?<version>.*)$"
     }
   ]
 }

vortex-duckdb/build.rs

@@ -6,13 +6,13 @@
 use std::path::PathBuf;
 use std::{env, fs};
 
-const DUCKDB_VERSION: &str = "1.3.2";
+const DUCKDB_VERSION: &str = "1.3.1";
 const DUCKDB_BASE_URL: &str = "https://github.com/duckdb/duckdb/releases/download";
 
 fn download_duckdb_lib_archive() -> Result<PathBuf, Box<dyn std::error::Error>> {
     let manifest_dir = PathBuf::from(env::var("CARGO_MANIFEST_DIR")?);
     let target_dir = manifest_dir.parent().unwrap().join("target");
-    let duckdb_dir = target_dir.join(format!("duckdb-lib-v{DUCKDB_VERSION}"));
+    let duckdb_dir = target_dir.join("duckdb-lib");
 
     let target = env::var("TARGET")?;
     let (platform, arch) = match target.as_str() {
@@ -27,7 +27,8 @@ fn download_duckdb_lib_archive() -> Result<PathBuf, Box<dyn std::error::Error>>
     let url = format!("{DUCKDB_BASE_URL}/v{DUCKDB_VERSION}/{archive_name}");
     let archive_path = duckdb_dir.join(&archive_name);
 
-    // Create directory if it doesn't exist.
+    // Recreate the duckdb directory
+    let _ = fs::remove_dir_all(&duckdb_dir);
     fs::create_dir_all(&duckdb_dir)?;
 
     if !archive_path.exists() {
@@ -127,9 +128,7 @@ fn main() {
     // Download, extract and symlink DuckDB source code.
     let zip_source_path = download_duckdb_source_archive().unwrap();
     let extracted_source_path = extract_duckdb_source(zip_source_path).unwrap();
-    if duckdb_repo.exists() {
-        fs::remove_file(&duckdb_repo).unwrap();
-    }
+    let _ = fs::remove_dir_all(&duckdb_repo);
     std::os::unix::fs::symlink(&extracted_source_path, &duckdb_repo).unwrap();
 
     // Generate the _imported_ bindings from our C++ code.