Skip to content

Commit 8503b98

Browse files
joseph-isaacsclaude
andcommitted
fix: Exclude bench-vortex from Windows tests
bench-vortex has dependencies that are problematic on Windows (protoc). Exclude it from the test run and simplify protoc installation back to the standard approach. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Joe Isaacs <[email protected]>
1 parent 77e3f01 commit 8503b98

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

.github/actions/setup-rust/action.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,7 @@ runs:
5151
run: echo "PATH=$PATH" >> $GITHUB_ENV
5252

5353
- name: Install Protoc (for lance-encoding build step)
54-
if: runner.os != 'Windows'
5554
uses: arduino/setup-protoc@v3
5655
with:
5756
version: "29.3"
5857
repo-token: ${{ inputs.repo-token }}
59-
60-
- name: Install Protoc on Windows
61-
if: runner.os == 'Windows'
62-
shell: bash
63-
run: |
64-
choco install protoc --version=29.3 -y
65-
echo "C:\ProgramData\chocolatey\lib\protoc\tools\bin" >> $GITHUB_PATH

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ jobs:
440440
with:
441441
tool: nextest
442442
- name: Rust Tests
443-
run: cargo nextest run --locked --workspace --all-features --no-fail-fast
443+
run: cargo nextest run --locked --workspace --all-features --no-fail-fast --exclude bench-vortex
444444

445445
build-java:
446446
name: "Java"

0 commit comments

Comments
 (0)