Skip to content

Commit 85c2e2f

Browse files
perf(ci): skip rust-cache on runs-on runners with S3 sccache (#5570)
Signed-off-by: Joe Isaacs <[email protected]>
1 parent de9f463 commit 85c2e2f

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

.github/actions/setup-rust/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ runs:
4141
uses: Swatinem/rust-cache@v2
4242
with:
4343
save-if: ${{ github.ref_name == 'develop' }}
44-
shared-key: "rust-cache-${{ runner.os }}-${{ runner.environment }}" # To allow reuse across jobs
44+
shared-key: "rust-cache-${{ runner.os }}-${{ runner.arch }}-${{ runner.environment }}"
4545

4646
- name: Rust Compile Cache
4747
uses: mozilla-actions/[email protected]

.github/workflows/ci.yml

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,12 @@ jobs:
5353
with:
5454
sync: false
5555
prune-cache: false
56+
# Use uvx for ruff to avoid building the Rust extension (saves ~4.5 min)
5657
- name: Python Lint - Format
57-
run: uv run ruff format --check .
58+
run: uvx ruff format --check .
5859
- name: Python Lint - Ruff
59-
run: uv run ruff check .
60+
run: uvx ruff check .
61+
# PyRight needs the project for type information, so use uv run
6062
- name: Python Lint - PyRight
6163
run: uv run basedpyright vortex-python
6264

@@ -97,7 +99,21 @@ jobs:
9799
uv run --all-packages make html
98100
working-directory: docs/
99101

102+
python-wheel-build:
103+
name: "Python (wheel build)"
104+
runs-on: ubuntu-latest
105+
timeout-minutes: 120
106+
steps:
107+
- uses: actions/checkout@v6
108+
- uses: ./.github/actions/setup-rust
109+
with:
110+
repo-token: ${{ secrets.GITHUB_TOKEN }}
100111
- uses: mlugg/setup-zig@v2
112+
- name: Install uv
113+
uses: spiraldb/actions/.github/actions/[email protected]
114+
with:
115+
sync: false
116+
prune-cache: false
101117
- name: Ensure wheel and sdist can be built on Linux - PyVortex
102118
shell: bash
103119
run: |
@@ -324,10 +340,12 @@ jobs:
324340
run: |
325341
cargo build -p vortex-ffi
326342
cargo run -p vortex-ffi --example hello_vortex
343+
- name: Install llvm-tools-preview
344+
run: rustup component add llvm-tools-preview
327345
- name: Generate coverage report
328346
run: |
329-
rustup component add llvm-tools-preview
330347
grcov . --binary-path target/debug/ -s . -t lcov --llvm --ignore-not-existing \
348+
--threads $(nproc) \
331349
--ignore '../*' --ignore '/*' --ignore 'fuzz/*' --ignore 'bench-vortex/*' \
332350
--ignore 'home/*' --ignore 'xtask/*' --ignore 'target/*' --ignore 'vortex-error/*' \
333351
--ignore 'vortex-python/*' --ignore 'vortex-jni/*' --ignore 'vortex-flatbuffers/*' \

0 commit comments

Comments
 (0)