Skip to content

Commit 875e96e

Browse files
committed
Some vx-bench fixes
Signed-off-by: Adam Gutglick <[email protected]>
1 parent eab8dcb commit 875e96e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

bench-orchestrator/bench_orchestrator/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ def list_runs(
288288
return
289289

290290
table = Table(title="Benchmark Runs")
291-
table.add_column("Run ID", style="cyan")
291+
table.add_column("Run ID", style="cyan", no_wrap=True)
292292
table.add_column("Label", style="green")
293293
table.add_column("Benchmark")
294294
table.add_column("Engines")
@@ -298,7 +298,7 @@ def list_runs(
298298
for run in runs:
299299
status = "[yellow]partial[/yellow]" if run.partial else "[green]complete[/green]"
300300
table.add_row(
301-
run.run_id[:30] + "..." if len(run.run_id) > 30 else run.run_id,
301+
run.run_id,
302302
run.label or "-",
303303
run.benchmark,
304304
", ".join(run.engines),

bench-orchestrator/bench_orchestrator/storage/schema.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ def to_dict(self) -> dict[str, Any]:
131131

132132
@classmethod
133133
def from_dict(cls, data: dict[str, Any]) -> "RunMetadata":
134+
print(f"partial: {data.get('partial')}")
134135
return cls(
135136
run_id=data["run_id"],
136137
timestamp=datetime.fromisoformat(data["timestamp"]),

bench-orchestrator/bench_orchestrator/storage/store.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ def __exit__(self, exc_type, exc_val, exc_tb) -> None:
8181
# Mark as partial if there was an exception
8282
if exc_type is not None:
8383
self.metadata.partial = True
84-
else:
85-
self.metadata.completed_at = datetime.now()
84+
85+
self.metadata.completed_at = datetime.now()
8686

8787
# Write metadata
8888
with open(self.run_dir / "metadata.json", "w") as f:
@@ -146,7 +146,6 @@ def create_run(self, config: RunConfig, build_config: BuildConfig) -> Iterator[R
146146
env_triple=env_triple,
147147
rustflags=build_config.rustflags,
148148
profile=build_config.profile,
149-
partial=True, # Will be set to False on successful completion
150149
)
151150

152151
ctx = RunContext(run_dir, metadata)

0 commit comments

Comments
 (0)