few more

Signed-off-by: Andrew Duffy <[email protected]>

Author: a10y

vortex-vector/src/binaryview/vector_mut.rs

@@ -146,10 +146,10 @@ impl<T: BinaryViewType> VectorMutOps for BinaryViewVectorMut<T> {
         }
 
         // rewrite the views using our lookup table
-        let new_views = rewrite_views(other.views().iter().copied(), &buf_index_lookup);
+        let new_views_iter = rewrite_views(other.views().iter().copied(), &buf_index_lookup);
 
         self.buffers.extend(new_buffers);
-        self.views.extend(new_views);
+        self.views.extend(new_views_iter);
         self.validity.append_mask(other.validity())
     }
 

vortex-vector/src/binaryview/view.rs

@@ -274,7 +274,7 @@ impl fmt::Debug for BinaryView {
 /// 2. Points at a valid range of owned buffer memory, and the bytes stored there conform to
 ///    the type constraints as defined by the `validator`.
 pub(super) fn validate_views<ValidateFn, IsValidFn>(
-    views: impl AsRef<[BinaryView]>,
+    views: &[BinaryView],
     buffers: impl AsRef<[ByteBuffer]>,
     validity: IsValidFn,
     validator: ValidateFn,