Temp fix: Make take bound by Copy instead of NativePType (#5666)

Just so we don't have to refactor the SIMD code to not rely on the
`PTYPE` constant of `NativePType`.

This will unblock being able to implement `take` for `DecimalVector` and
then `batch_execute` for `DictArray`.

---------

Signed-off-by: Connor Tsui <[email protected]>

Author: connortsui20

vortex-compute/src/take/buffer.rs

@@ -2,12 +2,11 @@
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
 use vortex_buffer::Buffer;
-use vortex_dtype::NativePType;
 use vortex_dtype::UnsignedPType;
 
 use crate::take::Take;
 
-impl<T: NativePType, I: UnsignedPType> Take<[I]> for &Buffer<T> {
+impl<T: Copy, I: UnsignedPType> Take<[I]> for &Buffer<T> {
     type Output = Buffer<T>;
 
     fn take(self, indices: &[I]) -> Buffer<T> {

vortex-compute/src/take/slice/mod.rs

@@ -4,7 +4,6 @@
 //! Take function implementations on slices.
 
 use vortex_buffer::Buffer;
-use vortex_dtype::NativePType;
 use vortex_dtype::UnsignedPType;
 
 use crate::take::Take;
@@ -13,10 +12,13 @@ pub mod avx2;
 pub mod portable;
 
 /// Specialized implementation for non-nullable indices.
-impl<T: NativePType, I: UnsignedPType> Take<[I]> for &[T] {
+impl<T: Copy, I: UnsignedPType> Take<[I]> for &[T] {
     type Output = Buffer<T>;
 
     fn take(self, indices: &[I]) -> Buffer<T> {
+        // TODO(connor): Make the SIMD implementations bound by `Copy` instead of `NativePType`.
+        /*
+
         #[cfg(vortex_nightly)]
         {
             return portable::take_portable(self, indices);
@@ -30,6 +32,8 @@ impl<T: NativePType, I: UnsignedPType> Take<[I]> for &[T] {
             }
         }
 
+        */
+
         #[allow(unreachable_code, reason = "`vortex_nightly` path returns early")]
         take_scalar(self, indices)
     }
@@ -40,6 +44,6 @@ impl<T: NativePType, I: UnsignedPType> Take<[I]> for &[T] {
     reason = "Compiler may see this as unused based on enabled features"
 )]
 #[inline]
-fn take_scalar<T: NativePType, I: UnsignedPType>(buffer: &[T], indices: &[I]) -> Buffer<T> {
+fn take_scalar<T: Copy, I: UnsignedPType>(buffer: &[T], indices: &[I]) -> Buffer<T> {
     indices.iter().map(|idx| buffer[idx.as_()]).collect()
 }