fix: duckdb_logical_type leak (#3630)

0ax1 · web-flow · commit 8ac9f67c3e19 · 2025-06-24T15:06:53.000-04:00
`duckdb_create_vector` does not take ownership of the heap allocated
memory but copies the logical type by value.

Signed-off-by: Alexander Droste &lt;alexander.droste@protonmail.com&gt;
diff --git a/vortex-duckdb/src/duckdb/vector.rs b/vortex-duckdb/src/duckdb/vector.rs
@@ -12,9 +12,8 @@ wrapper!(Vector, cpp::duckdb_vector, cpp::duckdb_destroy_vector);
 
 impl Vector {
     /// Create a new vector with the given type and capacity.
-    /// Takes logical_type by ownership.
     pub fn with_capacity(logical_type: LogicalType, len: usize) -> Self {
-        unsafe { Self::own(cpp::duckdb_create_vector(logical_type.into_ptr(), len as _)) }
+        unsafe { Self::own(cpp::duckdb_create_vector(logical_type.as_ptr(), len as _)) }
     }
 
     /// Converts the vector to a constant value.

Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,8 @@ wrapper!(Vector, cpp::duckdb_vector, cpp::duckdb_destroy_vector);`
`12`	`12`
`13`	`13`	`impl Vector {`
`14`	`14`	`/// Create a new vector with the given type and capacity.`
`15`		`- /// Takes logical_type by ownership.`
`16`	`15`	`pub fn with_capacity(logical_type: LogicalType, len: usize) -> Self {`
`17`		`- unsafe { Self::own(cpp::duckdb_create_vector(logical_type.into_ptr(), len as _)) }`
	`16`	`+ unsafe { Self::own(cpp::duckdb_create_vector(logical_type.as_ptr(), len as _)) }`
`18`	`17`	`}`
`19`	`18`
`20`	`19`	`/// Converts the vector to a constant value.`