wip

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

encodings/alp/src/alp/compress.rs

@@ -63,7 +63,10 @@ pub fn alp_encode(parray: &PrimitiveArray, exponents: Option<Exponents>) -> Vort
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "u64 index cast to usize is safe for reasonable array sizes"
+)]
 fn alp_encode_components_typed<T>(
     values: &PrimitiveArray,
     exponents: Option<Exponents>,

encodings/alp/src/alp/mod.rs

@@ -268,7 +268,10 @@ pub trait ALPFloat: private::Sealed + Float + Display + NativePType {
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "intentional truncation for ALP encoding"
+)]
 fn encode_chunk_unchecked<T: ALPFloat>(
     chunk: &[T],
     exp: Exponents,
@@ -376,7 +379,10 @@ impl ALPFloat for f32 {
     ];
 
     #[inline(always)]
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "intentional float to int truncation for ALP encoding"
+    )]
     fn as_int(self) -> Self::ALPInt {
         self as _
     }
@@ -448,7 +454,10 @@ impl ALPFloat for f64 {
     ];
 
     #[inline(always)]
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "intentional float to int truncation for ALP encoding"
+    )]
     fn as_int(self) -> Self::ALPInt {
         self as _
     }

encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs

@@ -332,7 +332,10 @@ pub fn find_best_bit_width(ptype: PType, bit_width_freq: &[usize]) -> VortexResu
 
 /// Assuming exceptions cost 1 value + 1 u32 index, figure out the best bit-width to use.
 /// We could try to be clever, but we can never really predict how the exceptions will compress.
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "bit_width is bounded by check above and result fits in u8"
+)]
 fn best_bit_width(bit_width_freq: &[usize], bytes_per_exception: usize) -> VortexResult<u8> {
     if bit_width_freq.len() > u8::MAX as usize {
         vortex_bail!("Too many bit widths");

encodings/fastlanes/src/for/array/for_compress.rs

@@ -27,7 +27,10 @@ impl FoRArray {
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "generic type T handles appropriate widths"
+)]
 fn compress_primitive<T: NativePType + WrappingSub + PrimInt>(
     parray: PrimitiveArray,
     min: T,

encodings/runend/src/compute/take.rs

@@ -25,7 +25,10 @@ use crate::RunEndArray;
 use crate::RunEndVTable;
 
 impl TakeKernel for RunEndVTable {
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "index cast to usize inside macro"
+    )]
     fn take(&self, array: &RunEndArray, indices: &dyn Array) -> VortexResult<ArrayRef> {
         let primitive_indices = indices.to_primitive();
 

vortex-array/src/arrays/decimal/array.rs

@@ -253,7 +253,10 @@ impl DecimalArray {
         )
     }
 
-    #[allow(clippy::cognitive_complexity)]
+    #[expect(
+        clippy::cognitive_complexity,
+        reason = "complexity from nested match_each_* macros"
+    )]
     pub fn patch(self, patches: &Patches) -> Self {
         let offset = patches.offset();
         let patch_indices = patches.indices().to_primitive();

vortex-array/src/arrays/decimal/compute/sum.rs

@@ -49,7 +49,10 @@ macro_rules! sum_decimal {
 }
 
 impl SumKernel for DecimalVTable {
-    #[allow(clippy::cognitive_complexity)]
+    #[expect(
+        clippy::cognitive_complexity,
+        reason = "complexity from nested match_each_* macros"
+    )]
     fn sum(&self, array: &DecimalArray, accumulator: &Scalar) -> VortexResult<Scalar> {
         let decimal_dtype = array.decimal_dtype();
 

vortex-array/src/arrays/primitive/compute/take/avx2.rs

@@ -51,7 +51,10 @@ use crate::validity::Validity;
 pub(super) struct TakeKernelAVX2;
 
 impl TakeImpl for TakeKernelAVX2 {
-    #[allow(clippy::cognitive_complexity)]
+    #[expect(
+        clippy::cognitive_complexity,
+        reason = "complexity from nested match_each_* macros"
+    )]
     #[inline(always)]
     fn take(
         &self,

vortex-array/src/arrow/compute/to_arrow/canonical.rs

@@ -87,7 +87,10 @@ use crate::compute::cast;
 pub(super) struct ToArrowCanonical;
 
 impl Kernel for ToArrowCanonical {
-    #[allow(clippy::cognitive_complexity)]
+    #[expect(
+        clippy::cognitive_complexity,
+        reason = "large match statement for all canonical types"
+    )]
     fn invoke(&self, args: &InvocationArgs) -> VortexResult<Option<Output>> {
         let ToArrowArgs {
             array,

vortex-btrblocks/src/integer.rs

@@ -397,7 +397,10 @@ impl Scheme for BitPackingScheme {
         BITPACKING_SCHEME
     }
 
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "bit width fits in smaller integer types"
+    )]
     fn expected_compression_ratio(
         &self,
         stats: &IntegerStats,
@@ -424,7 +427,10 @@ impl Scheme for BitPackingScheme {
         )
     }
 
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "bit width fits in smaller integer types"
+    )]
     fn compress(
         &self,
         stats: &IntegerStats,