wip

joseph-isaacs · joseph-isaacs · commit 93c4354e5e5d · 2025-11-24T12:18:52.000Z
Signed-off-by: Joe Isaacs &lt;joe.isaacs@live.co.uk&gt;
diff --git a/encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs b/encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs
@@ -212,7 +212,6 @@ impl OperationsVTable<DecimalBytePartsVTable> for DecimalBytePartsVTable {
         }
     }
 
-    #[allow(clippy::useless_conversion)]
     fn scalar_at(array: &DecimalBytePartsArray, index: usize) -> Scalar {
         // TODO(joe): support parts len != 1
         let scalar = array.msp.scalar_at(index);
diff --git a/vortex-array/benches/take_patches.rs b/vortex-array/benches/take_patches.rs
@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![allow(clippy::unwrap_used)]
 #![allow(clippy::cast_possible_truncation)]
 
 use divan::Bencher;
diff --git a/vortex-array/src/compute/is_sorted.rs b/vortex-array/src/compute/is_sorted.rs
@@ -201,7 +201,6 @@ pub trait IsSortedKernel: VTable {
     fn is_strict_sorted(&self, array: &Self::Array) -> VortexResult<Option<bool>>;
 }
 
-#[allow(clippy::wrong_self_convention)]
 /// Helper methods to check sortedness with strictness
 pub trait IsSortedIteratorExt: Iterator
 where
diff --git a/vortex-btrblocks/benches/compress.rs b/vortex-btrblocks/benches/compress.rs
@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![allow(clippy::unwrap_used)]
 #![allow(unexpected_cfgs)]
 
 #[cfg(not(codspeed))]
diff --git a/vortex-btrblocks/benches/dict_encode.rs b/vortex-btrblocks/benches/dict_encode.rs
@@ -1,8 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![allow(clippy::unwrap_used)]
-
 use divan::Bencher;
 use vortex_array::IntoArray;
 use vortex_array::arrays::{BoolArray, PrimitiveArray};
diff --git a/vortex-btrblocks/benches/stats_calc.rs b/vortex-btrblocks/benches/stats_calc.rs
@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![allow(clippy::cast_possible_truncation, clippy::use_debug)]
 #![allow(unexpected_cfgs)]
 
 #[cfg(not(codspeed))]
diff --git a/vortex-btrblocks/src/float/dictionary.rs b/vortex-btrblocks/src/float/dictionary.rs
@@ -64,7 +64,6 @@ macro_rules! impl_encode {
     ($typ:ty, $utyp:ty, $($ityp:ty),+) => {
         $(
         impl Encode<$typ, $ityp> for DictEncoder {
-            #[allow(clippy::cast_possible_truncation)]
             fn encode(distinct: &[$typ], values: &[$typ]) -> Buffer<$ityp> {
                 let mut codes =
                     vortex_utils::aliases::hash_map::HashMap::<$utyp, $ityp>::with_capacity(
diff --git a/vortex-btrblocks/src/integer.rs b/vortex-btrblocks/src/integer.rs
@@ -387,7 +387,6 @@ impl Scheme for BitPackingScheme {
         BITPACKING_SCHEME
     }
 
-    #[allow(clippy::cast_possible_truncation)]
     fn expected_compression_ratio(
         &self,
         stats: &IntegerStats,
@@ -414,7 +413,6 @@ impl Scheme for BitPackingScheme {
         )
     }
 
-    #[allow(clippy::cast_possible_truncation)]
     fn compress(
         &self,
         stats: &IntegerStats,
diff --git a/vortex-btrblocks/src/integer/dictionary.rs b/vortex-btrblocks/src/integer/dictionary.rs
@@ -43,7 +43,6 @@ macro_rules! typed_encode {
 }
 
 /// Compresses an integer array into a dictionary arrays according to attached stats.
-#[allow(clippy::cognitive_complexity)]
 pub fn dictionary_encode(stats: &IntegerStats) -> DictArray {
     // We need to preserve the nullability somehow from the original
     let src_validity = stats.src.validity();
@@ -72,7 +71,6 @@ macro_rules! impl_encode {
     ($typ:ty, $($ityp:ty),+) => {
         $(
         impl Encode<$typ, $ityp> for DictEncoder {
-            #[allow(clippy::cast_possible_truncation)]
             fn encode(distinct: &[$typ], values: &[$typ]) -> Buffer<$ityp> {
                 let mut codes =
                     vortex_utils::aliases::hash_map::HashMap::<$typ, $ityp>::with_capacity(
diff --git a/vortex-btrblocks/src/string.rs b/vortex-btrblocks/src/string.rs
@@ -30,7 +30,6 @@ pub struct StringStats {
 }
 
 /// Estimate the number of distinct strings in the var bin view array.
-#[allow(clippy::cast_possible_truncation)]
 fn estimate_distinct_count(strings: &VarBinViewArray) -> u32 {
     let views = strings.views();
     // Iterate the views. Two strings which are equal must have the same first 8-bytes.
diff --git a/vortex-buffer/benches/vortex_bitbuffer.rs b/vortex-buffer/benches/vortex_bitbuffer.rs
@@ -1,8 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![allow(clippy::unwrap_used)]
-
 use std::iter::Iterator;
 
 use arrow_buffer::{BooleanBuffer, BooleanBufferBuilder};
diff --git a/vortex-buffer/benches/vortex_buffer.rs b/vortex-buffer/benches/vortex_buffer.rs
@@ -1,8 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![allow(clippy::unwrap_used)]
-
 use std::iter::Iterator;
 
 use arrow_buffer::{ArrowNativeType, MutableBuffer, ScalarBuffer};
diff --git a/vortex-buffer/src/lib.rs b/vortex-buffer/src/lib.rs
@@ -2,8 +2,6 @@
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
 #![deny(missing_docs)]
-// cudarc HostSlice has len and is_empty methods that duplicate BufferMut methods.
-#![allow(clippy::same_name_method)]
 
 //! A library for working with custom aligned buffers of sized values.
 //!
diff --git a/vortex-buffer/src/string.rs b/vortex-buffer/src/string.rs
@@ -69,10 +69,14 @@ impl TryFrom<ByteBuffer> for BufferString {
 
     fn try_from(value: ByteBuffer) -> Result<Self, Self::Error> {
         simdutf8::basic::from_utf8(value.as_ref()).map_err(|_| {
-            #[allow(clippy::unwrap_used)]
             // run validation using `compat` package to get more detailed error message
-            let err = simdutf8::compat::from_utf8(value.as_ref()).unwrap_err();
-            vortex_err!("invalid utf-8: {err}")
+            match simdutf8::compat::from_utf8(value.as_ref()) {
+                Ok(_) => {
+                    // This should never happen since basic::from_utf8 already failed
+                    vortex_err!("invalid utf-8: unknown error")
+                }
+                Err(err) => vortex_err!("invalid utf-8: {err}"),
+            }
         })?;
         Ok(Self(value))
     }
diff --git a/vortex-cxx/src/expr.rs b/vortex-cxx/src/expr.rs
@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+#![allow(clippy::boxed_local)]
+
 use vortex::dtype::FieldName;
 use vortex::expr::Expression;
 
diff --git a/vortex-cxx/src/lib.rs b/vortex-cxx/src/lib.rs
@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-#![allow(clippy::boxed_local)]
 mod dtype;
 mod expr;
 mod read;

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,6 @@ impl OperationsVTable<DecimalBytePartsVTable> for DecimalBytePartsVTable {`
`212`	`212`	`}`
`213`	`213`	`}`
`214`	`214`
`215`		`- #[allow(clippy::useless_conversion)]`
`216`	`215`	`fn scalar_at(array: &DecimalBytePartsArray, index: usize) -> Scalar {`
`217`	`216`	`// TODO(joe): support parts len != 1`
`218`	`217`	`let scalar = array.msp.scalar_at(index);`
Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,6 @@ pub trait IsSortedKernel: VTable {`
`201`	`201`	`fn is_strict_sorted(&self, array: &Self::Array) -> VortexResult<Option<bool>>;`
`202`	`202`	`}`
`203`	`203`
`204`		`-#[allow(clippy::wrong_self_convention)]`
`205`	`204`	`/// Helper methods to check sortedness with strictness`
`206`	`205`	`pub trait IsSortedIteratorExt: Iterator`
`207`	`206`	`where`
Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,6 @@ impl Scheme for BitPackingScheme {`
`387`	`387`	`BITPACKING_SCHEME`
`388`	`388`	`}`
`389`	`389`
`390`		`- #[allow(clippy::cast_possible_truncation)]`
`391`	`390`	`fn expected_compression_ratio(`
`392`	`391`	`&self,`
`393`	`392`	`stats: &IntegerStats,`
`@@ -414,7 +413,6 @@ impl Scheme for BitPackingScheme {`
`414`	`413`	`)`
`415`	`414`	`}`
`416`	`415`
`417`		`- #[allow(clippy::cast_possible_truncation)]`
`418`	`416`	`fn compress(`
`419`	`417`	`&self,`
`420`	`418`	`stats: &IntegerStats,`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ pub struct StringStats {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`/// Estimate the number of distinct strings in the var bin view array.`
`33`		`-#[allow(clippy::cast_possible_truncation)]`
`34`	`33`	`fn estimate_distinct_count(strings: &VarBinViewArray) -> u32 {`
`35`	`34`	`let views = strings.views();`
`36`	`35`	`// Iterate the views. Two strings which are equal must have the same first 8-bytes.`