Skip to content

Commit 9564a65

Browse files
committed
wip fallible vortex
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
1 parent e54f6a7 commit 9564a65

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

vortex-array/src/arrays/scalar_fn/vtable/operations.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// SPDX-License-Identifier: Apache-2.0
22
// SPDX-FileCopyrightText: Copyright the Vortex contributors
33

4-
use vortex_error::VortexExpect;
54
use vortex_error::VortexResult;
65
use vortex_scalar::Scalar;
76

@@ -31,10 +30,7 @@ impl OperationsVTable<ScalarFnVTable> for ScalarFnVTable {
3130
ctx: &mut ctx,
3231
};
3332

34-
let result = array
35-
.scalar_fn
36-
.execute(args)
37-
.vortex_expect("todo vortex result return");
33+
let result = array.scalar_fn.execute(args)?;
3834

3935
match result {
4036
ExecutionResult::Array(arr) => {

vortex-error/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,6 @@ where
310310
#[inline(always)]
311311
fn vortex_expect(self, msg: &'static str) -> Self::Output {
312312
self.map_err(|err| err.into())
313-
.inspect_err(|e| println!("got a big ERROR {e}"))
314313
.unwrap_or_else(|e| vortex_panic!(e.with_context(msg.to_string())))
315314
}
316315
}

0 commit comments

Comments
 (0)