chore[*]: prefer #[expect(..)] over #[allow(..)] p2 (#5533)

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

bench-vortex/src/benchmark_driver.rs

@@ -152,7 +152,10 @@ pub fn run_benchmark<B: Benchmark>(benchmark: B, config: DriverConfig) -> Result
     )
 }
 
-#[allow(clippy::too_many_arguments)]
+#[expect(
+    clippy::too_many_arguments,
+    reason = "all arguments needed for benchmark execution"
+)]
 fn execute_queries<B: Benchmark>(
     queries: &[(usize, String)],
     iterations: usize,

bench-vortex/src/statpopgen/builder.rs

@@ -264,7 +264,6 @@ impl<'a> GnomADBuilder<'a> {
         }
     }
 
-    #[allow(clippy::cognitive_complexity)]
     pub fn consume_record(&mut self, header: &Header, record: &mut Record) -> VortexResult<()> {
         self.CHROM_builder
             .append_value(record.reference_sequence_name());
@@ -352,7 +351,6 @@ impl<'a> GnomADBuilder<'a> {
         Ok(())
     }
 
-    #[allow(clippy::cognitive_complexity)]
     pub fn consume_info(&mut self, header: &Header, info: Info) -> VortexResult<()> {
         info.iter(header)
             .process_results(|iter| -> VortexResult<()> {
@@ -376,7 +374,6 @@ impl<'a> GnomADBuilder<'a> {
             })?
     }
 
-    #[allow(clippy::cognitive_complexity)]
     pub fn finish(mut self) -> Result<RecordBatch, ArrowError> {
         let len = self.CHROM_builder.len();
         assert_eq!(len, self.POS_builder.len());

bench-vortex/src/tpch/dbgen.rs

@@ -74,7 +74,10 @@ impl DBGen {
 }
 
 impl DBGen {
-    #[allow(clippy::unwrap_in_result)]
+    #[expect(
+        clippy::unwrap_in_result,
+        reason = "benchmark code where unwrap is acceptable"
+    )]
     /// Generate the TPC-H data files for use with benchmarks.
     pub fn generate(&self) -> anyhow::Result<PathBuf> {
         let sh = Shell::new()?;

encodings/alp/src/alp/compress.rs

@@ -63,7 +63,10 @@ pub fn alp_encode(parray: &PrimitiveArray, exponents: Option<Exponents>) -> Vort
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "u64 index cast to usize is safe for reasonable array sizes"
+)]
 fn alp_encode_components_typed<T>(
     values: &PrimitiveArray,
     exponents: Option<Exponents>,

encodings/alp/src/alp/mod.rs

@@ -268,7 +268,10 @@ pub trait ALPFloat: private::Sealed + Float + Display + NativePType {
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "intentional truncation for ALP encoding"
+)]
 fn encode_chunk_unchecked<T: ALPFloat>(
     chunk: &[T],
     exp: Exponents,
@@ -376,7 +379,10 @@ impl ALPFloat for f32 {
     ];
 
     #[inline(always)]
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "intentional float to int truncation for ALP encoding"
+    )]
     fn as_int(self) -> Self::ALPInt {
         self as _
     }
@@ -448,7 +454,10 @@ impl ALPFloat for f64 {
     ];
 
     #[inline(always)]
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "intentional float to int truncation for ALP encoding"
+    )]
     fn as_int(self) -> Self::ALPInt {
         self as _
     }

encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs

@@ -332,7 +332,10 @@ pub fn find_best_bit_width(ptype: PType, bit_width_freq: &[usize]) -> VortexResu
 
 /// Assuming exceptions cost 1 value + 1 u32 index, figure out the best bit-width to use.
 /// We could try to be clever, but we can never really predict how the exceptions will compress.
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "bit_width is bounded by check above and result fits in u8"
+)]
 fn best_bit_width(bit_width_freq: &[usize], bytes_per_exception: usize) -> VortexResult<u8> {
     if bit_width_freq.len() > u8::MAX as usize {
         vortex_bail!("Too many bit widths");

encodings/fastlanes/src/for/array/for_compress.rs

@@ -27,7 +27,6 @@ impl FoRArray {
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
 fn compress_primitive<T: NativePType + WrappingSub + PrimInt>(
     parray: PrimitiveArray,
     min: T,

encodings/runend/src/compute/take.rs

@@ -25,7 +25,10 @@ use crate::RunEndArray;
 use crate::RunEndVTable;
 
 impl TakeKernel for RunEndVTable {
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        reason = "index cast to usize inside macro"
+    )]
     fn take(&self, array: &RunEndArray, indices: &dyn Array) -> VortexResult<ArrayRef> {
         let primitive_indices = indices.to_primitive();
 

encodings/sparse/src/lib.rs

@@ -386,7 +386,6 @@ impl ValidityVTable<SparseVTable> for SparseVTable {
         array.patches().values().all_invalid()
     }
 
-    #[allow(clippy::unnecessary_fallible_conversions)]
     fn validity_mask(array: &SparseArray) -> Mask {
         let fill_is_valid = array.fill_scalar().is_valid();
         let values_validity = array.patches().values().validity_mask();

vortex-array/src/arrays/decimal/array.rs

@@ -253,7 +253,10 @@ impl DecimalArray {
         )
     }
 
-    #[allow(clippy::cognitive_complexity)]
+    #[expect(
+        clippy::cognitive_complexity,
+        reason = "complexity from nested match_each_* macros"
+    )]
     pub fn patch(self, patches: &Patches) -> Self {
         let offset = patches.offset();
         let patch_indices = patches.indices().to_primitive();