Commit 9af4e14
authored
Chore: Add all logical bool implementations + refactor (#5669)
This PR consolidates and finalizes a lot of the boolean and Kleene
logic, and also deduplicates a bunch of code.
Instead of having each of the operands in separate modules, I grouped
them into logical operands, kleene operands, and `not` by itself since
it is the only unary operator.
The convenience trait impls all have the same 3 impls: for
`&BoolScalar`, `&BoolVector`, `&BoolDatum`.
```rust
impl LogicalAndKleene for &BoolScalar { ... }
impl LogicalAndKleene for &BoolVector { ... }
impl LogicalAndKleene for &BoolDatum { ... }
```
Also adds more tests.
---------
Signed-off-by: Connor Tsui <[email protected]>1 parent ede0ad6 commit 9af4e14
File tree
10 files changed
+1082
-678
lines changed- vortex-array/src/scalar_fns/binary
- vortex-compute/src/logical
10 files changed
+1082
-678
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
107 | 112 | | |
108 | 113 | | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | 114 | | |
113 | 115 | | |
114 | 116 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments