Skip to content

Commit 9d8bb1f

Browse files
authored
fix: JSON must not have trailing commas (#1680)
The commit-metadata job also tolerated sub-shell failures. I've already uploaded the missing commit entry (from the current tip) to S3.
1 parent 6c63cf9 commit 9d8bb1f

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/bench.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,11 @@ jobs:
2323
- name: Upload Commit Metadata
2424
shell: bash
2525
run: |
26+
set -Eeu -o pipefail -x
27+
2628
sudo apt-get update && sudo apt-get install -y jq
27-
bash scripts/cat-s3.sh vortex-benchmark-results-database commits.json <(bash scripts/commit-json.sh)
29+
bash scripts/commit-json.sh > new-commit.json
30+
bash scripts/cat-s3.sh vortex-benchmark-results-database commits.json new-commit.json
2831
bench:
2932
strategy:
3033
matrix:

scripts/commit-json.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ jq --compact-output '.' <<EOF
2929
"message": "$commit_title",
3030
"timestamp": "$commit_timestamp",
3131
"tree_id": "$tree_id",
32-
"url": "$repo_url/commit/$commit_id",
32+
"url": "$repo_url/commit/$commit_id"
3333
}
3434
EOF

0 commit comments

Comments
 (0)