Skip to content

Commit 9e22b2b

Browse files
committed
perf[ext]: pushdown filter + constant
Signed-off-by: Joe Isaacs <[email protected]>
1 parent 0fb522b commit 9e22b2b

File tree

1 file changed

+1
-9
lines changed
  • vortex-array/src/arrays/extension/vtable

1 file changed

+1
-9
lines changed

vortex-array/src/arrays/extension/vtable/rules.rs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,21 +84,13 @@ impl ArrayParentReduceRule<ExtensionVTable> for ExtensionScalarFnConstantPushDow
8484
return Ok(None);
8585
};
8686

87+
// ExtDType::eq_ignore_nullability checks id, metadata, and storage dtype
8788
if !ext_scalar
8889
.ext_dtype()
8990
.eq_ignore_nullability(child.ext_dtype())
9091
{
9192
return Ok(None);
9293
}
93-
94-
// The storage dtype must match.
95-
if !ext_scalar
96-
.ext_dtype()
97-
.storage_dtype()
98-
.eq_ignore_nullability(child.ext_dtype().storage_dtype())
99-
{
100-
return Ok(None);
101-
}
10294
}
10395

10496
// Build new children with storage arrays/scalars.

0 commit comments

Comments
 (0)