Vector Casting

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

vortex-array/src/expr/exprs/cast/mod.rs

@@ -4,17 +4,18 @@
 use std::fmt::Formatter;
 use std::ops::Deref;
 
-use crate::compute::cast as compute_cast;
-use crate::expr::expression::Expression;
-use crate::expr::{ChildName, ExprId, ExpressionView, StatsCatalog, VTable, VTableExt};
-use crate::stats::Stat;
-use crate::ArrayRef;
 use prost::Message;
 use vortex_dtype::DType;
 use vortex_error::{vortex_bail, vortex_err, VortexExpect, VortexResult};
 use vortex_proto::expr as pb;
 use vortex_vector::Vector;
 
+use crate::compute::cast as compute_cast;
+use crate::expr::expression::Expression;
+use crate::expr::{ChildName, ExprId, ExpressionView, StatsCatalog, VTable, VTableExt};
+use crate::stats::Stat;
+use crate::ArrayRef;
+
 /// A cast expression that converts values to a target data type.
 pub struct Cast;
 
@@ -130,15 +131,6 @@ impl VTable for Cast {
     }
 }
 
-/// A trait that defines the compute function for performing a cast.
-///
-/// The `try_cast` method attempts to convert the vector to the specified data type,
-/// returning a `VortexResult` that contains the casted vector or an error if the
-/// cast operation fails.
-trait VectorCast {
-    fn try_cast(self, dtype: &DType) -> VortexResult<Vector>;
-}
-
 /// Creates an expression that casts values to a target data type.
 ///
 /// Converts the input expression's values to the specified target type.

vortex-array/src/expr/exprs/select/mod.rs

@@ -5,18 +5,19 @@ pub mod transform;
 
 use std::fmt::{Display, Formatter};
 
-use crate::expr::expression::Expression;
-use crate::expr::field::DisplayFieldNames;
-use crate::expr::{ChildName, ExprId, ExpressionView, VTable, VTableExt};
-use crate::{ArrayRef, IntoArray, ToCanonical};
 use itertools::Itertools;
 use prost::Message;
 use vortex_dtype::{DType, FieldNames};
-use vortex_error::{vortex_bail, vortex_err, VortexExpect, VortexResult};
+use vortex_error::{VortexExpect, VortexResult, vortex_bail, vortex_err};
 use vortex_proto::expr::select_opts::Opts;
 use vortex_proto::expr::{FieldNames as ProtoFieldNames, SelectOpts};
 use vortex_vector::Vector;
 
+use crate::expr::expression::Expression;
+use crate::expr::field::DisplayFieldNames;
+use crate::expr::{ChildName, ExprId, ExpressionView, VTable, VTableExt};
+use crate::{ArrayRef, IntoArray, ToCanonical};
+
 #[derive(Debug, Clone, PartialEq, Eq, Hash)]
 pub enum FieldSelection {
     Include(FieldNames),

vortex-compute/src/cast/bool.rs

@@ -1,16 +1,17 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-use crate::cast::Cast;
 use num_traits::{One, Zero};
 use vortex_buffer::Buffer;
-use vortex_dtype::{match_each_native_ptype, DType};
-use vortex_error::{vortex_bail, VortexResult};
+use vortex_dtype::{DType, match_each_native_ptype};
+use vortex_error::{VortexResult, vortex_bail};
 use vortex_vector::bool::BoolVector;
 use vortex_vector::null::NullVector;
 use vortex_vector::primitive::PVector;
 use vortex_vector::{Vector, VectorOps};
 
+use crate::cast::Cast;
+
 impl Cast for BoolVector {
     fn cast(&self, dtype: &DType) -> VortexResult<Vector> {
         match dtype {

vortex-compute/src/cast/mod.rs

@@ -8,7 +8,7 @@ mod null;
 mod pvector;
 
 use vortex_dtype::DType;
-use vortex_error::{vortex_bail, VortexResult};
+use vortex_error::{VortexResult, vortex_bail};
 use vortex_vector::Vector;
 
 /// Trait for casting vectors to different data types.

vortex-compute/src/cast/null.rs

@@ -1,19 +1,20 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-use crate::cast::Cast;
 use vortex_dtype::DType;
-use vortex_error::{vortex_bail, VortexResult};
+use vortex_error::{VortexResult, vortex_bail};
 use vortex_vector::null::NullVector;
 use vortex_vector::{Vector, VectorMut, VectorMutOps, VectorOps};
 
+use crate::cast::Cast;
+
 impl Cast for NullVector {
     fn cast(&self, dtype: &DType) -> VortexResult<Vector> {
         if dtype.is_nullable() {
             // We can create an all-null vector of _any_ type.
             let mut vec = VectorMut::with_capacity(dtype, self.len());
             vec.append_nulls(self.len());
-            Ok(vec.freeze().into())
+            Ok(vec.freeze())
         } else {
             vortex_bail!("Cannot cast NullVector to non-nullable type {}", dtype);
         }

vortex-compute/src/cast/pvector.rs

@@ -1,12 +1,13 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-use crate::cast::Cast;
 use vortex_dtype::{DType, NativePType};
-use vortex_error::{vortex_bail, VortexResult};
+use vortex_error::{VortexResult, vortex_bail};
 use vortex_vector::null::NullVector;
 use vortex_vector::primitive::{PVector, PrimitiveVector};
-use vortex_vector::{match_each_pvector, Vector, VectorOps};
+use vortex_vector::{Vector, VectorOps, match_each_pvector};
+
+use crate::cast::Cast;
 
 impl Cast for PrimitiveVector {
     fn cast(&self, dtype: &DType) -> VortexResult<Vector> {

vortex-vector/src/primitive/generic.rs

@@ -8,7 +8,7 @@ use std::ops::RangeBounds;
 
 use vortex_buffer::Buffer;
 use vortex_dtype::NativePType;
-use vortex_error::{vortex_ensure, VortexExpect, VortexResult};
+use vortex_error::{VortexExpect, VortexResult, vortex_ensure};
 use vortex_mask::Mask;
 
 use crate::primitive::{PScalar, PVectorMut};