Use Validity::from when building validities (#1793)

Author: robert3005

encodings/runend/src/compress.rs

@@ -132,10 +132,7 @@ fn runend_encode_nullable_primitive<T: NativePType>(
 
     (
         ends.freeze(),
-        PrimitiveArray::new(
-            values,
-            Validity::Array(BoolArray::from(validity.finish()).into_array()),
-        ),
+        PrimitiveArray::new(values, Validity::from(validity.finish())),
     )
 }
 
@@ -190,10 +187,9 @@ pub fn runend_decode_typed_primitive<T: NativePType>(
             }
             PrimitiveArray::new(decoded, values_nullability.into())
         }
-        LogicalValidity::AllInvalid(_) => PrimitiveArray::new(
-            buffer![T::default(); length],
-            Validity::Array(BoolArray::from(BooleanBuffer::new_unset(length)).into_array()),
-        ),
+        LogicalValidity::AllInvalid(_) => {
+            PrimitiveArray::new(buffer![T::default(); length], Validity::AllInvalid)
+        }
         LogicalValidity::Array(array) => {
             let validity = array.into_bool()?.boolean_buffer();
             let mut decoded = BufferMut::with_capacity(length);
@@ -215,10 +211,7 @@ pub fn runend_decode_typed_primitive<T: NativePType>(
                     }
                 }
             }
-            PrimitiveArray::new(
-                decoded,
-                Validity::Array(BoolArray::from(decoded_validity.finish()).into_array()),
-            )
+            PrimitiveArray::new(decoded, Validity::from(decoded_validity.finish()))
         }
     })
 }
@@ -238,11 +231,10 @@ pub fn runend_decode_typed_bool(
             }
             BoolArray::new(decoded.finish(), values_nullability)
         }
-        LogicalValidity::AllInvalid(_) => BoolArray::try_new(
-            BooleanBuffer::new_unset(length),
-            Validity::Array(BoolArray::from(BooleanBuffer::new_unset(length)).into_array()),
-        )
-        .vortex_expect("invalid array"),
+        LogicalValidity::AllInvalid(_) => {
+            BoolArray::try_new(BooleanBuffer::new_unset(length), Validity::AllInvalid)
+                .vortex_expect("invalid array")
+        }
         LogicalValidity::Array(array) => {
             let validity = array.into_bool()?.boolean_buffer();
             let mut decoded = BooleanBufferBuilder::new(length);
@@ -264,10 +256,7 @@ pub fn runend_decode_typed_bool(
                     }
                 }
             }
-            BoolArray::try_new(
-                decoded.finish(),
-                Validity::Array(BoolArray::from(decoded_validity.finish()).into_array()),
-            )?
+            BoolArray::try_new(decoded.finish(), Validity::from(decoded_validity.finish()))?
         }
     })
 }

vortex-array/src/array/primitive/mod.rs

@@ -4,13 +4,11 @@ use std::sync::Arc;
 mod accessor;
 
 use arrow_buffer::BooleanBufferBuilder;
-use itertools::Itertools;
 use serde::{Deserialize, Serialize};
 use vortex_buffer::{Buffer, BufferMut, ByteBuffer};
 use vortex_dtype::{match_each_native_ptype, DType, NativePType, Nullability, PType};
 use vortex_error::{vortex_panic, VortexExpect as _, VortexResult};
 
-use crate::array::BoolArray;
 use crate::encoding::ids;
 use crate::iter::Accessor;
 use crate::stats::StatsSet;
@@ -50,7 +48,7 @@ impl PrimitiveArray {
                 validity: validity.to_metadata(len).vortex_expect("Invalid validity"),
             }),
             Some(buffer.into_byte_buffer()),
-            validity.into_array().into_iter().collect_vec().into(),
+            validity.into_array().into_iter().collect(),
             StatsSet::default(),
         )
         .and_then(|data| data.try_into())
@@ -92,10 +90,7 @@ impl PrimitiveArray {
                 }
             }
         }
-        Self::new(
-            values.freeze(),
-            Validity::Array(BoolArray::from(validity.finish()).into_array()),
-        )
+        Self::new(values.freeze(), Validity::from(validity.finish()))
     }
 
     pub fn validity(&self) -> Validity {