Skip to content

Commit a8cfcb7

Browse files
authored
remove unused scan driver options (#2342)
`FileType::Options` are propagated in creating a scan driver, future options could be added there
1 parent ea4a432 commit a8cfcb7

File tree

3 files changed

+0
-13
lines changed

3 files changed

+0
-13
lines changed

vortex-file/src/generic.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ pub struct GenericScanDriver<R> {
7171
}
7272

7373
impl<R: VortexReadAt> ScanDriver for GenericScanDriver<R> {
74-
type Options = GenericScanOptions;
75-
7674
fn segment_reader(&self) -> Arc<dyn AsyncSegmentReader> {
7775
self.segment_channel.reader()
7876
}

vortex-file/src/memory.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ impl FileType for InMemoryVortexFile {
3939
}
4040

4141
impl ScanDriver for InMemoryVortexFile {
42-
type Options = ();
43-
4442
fn segment_reader(&self) -> Arc<dyn AsyncSegmentReader> {
4543
Arc::new(self.clone())
4644
}

vortex-layout/src/scan/mod.rs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ use crate::segments::{AsyncSegmentReader, SegmentId};
2727
use crate::{ExprEvaluator, Layout, LayoutReader, LayoutReaderExt, RowMask};
2828

2929
pub trait ScanDriver: 'static + Sized {
30-
type Options: Default;
31-
3230
fn segment_reader(&self) -> Arc<dyn AsyncSegmentReader>;
3331

3432
/// Return a future that drives the I/O stream for the segment reader.
@@ -46,7 +44,6 @@ pub trait ScanDriver: 'static + Sized {
4644
/// A struct for building a scan operation.
4745
pub struct ScanBuilder<D: ScanDriver> {
4846
driver: D,
49-
driver_options: Option<D::Options>,
5047
task_executor: Option<Arc<dyn TaskExecutor>>,
5148
layout: Layout,
5249
ctx: ContextRef, // TODO(ngates): store this on larger context on Layout
@@ -63,7 +60,6 @@ impl<D: ScanDriver> ScanBuilder<D> {
6360
pub fn new(driver: D, layout: Layout, ctx: ContextRef) -> Self {
6461
Self {
6562
driver,
66-
driver_options: None,
6763
task_executor: None,
6864
layout,
6965
ctx,
@@ -123,11 +119,6 @@ impl<D: ScanDriver> ScanBuilder<D> {
123119
self
124120
}
125121

126-
pub fn with_options(mut self, options: D::Options) -> Self {
127-
self.driver_options = Some(options);
128-
self
129-
}
130-
131122
pub fn build(self) -> VortexResult<Scan<D>> {
132123
let projection = simplify_typed(self.projection, self.layout.dtype())?;
133124
let filter = self

0 commit comments

Comments
 (0)