fix[vortex-array]: correct convert to arrow from vortex (#5378)

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-array/src/arrow/datum.rs

@@ -41,7 +41,7 @@ impl Datum {
         })
     }
 
-    pub fn with_target_datatype(
+    pub fn try_new_with_target_datatype(
         array: &dyn Array,
         target_datatype: &DataType,
     ) -> VortexResult<Self> {
@@ -57,6 +57,10 @@ impl Datum {
             })
         }
     }
+
+    pub fn data_type(&self) -> &DataType {
+        self.array.data_type()
+    }
 }
 
 impl ArrowDatum for Datum {

vortex-array/src/compute/compare.rs

@@ -328,7 +328,7 @@ fn arrow_compare(
         BooleanArray::new(values, nulls)
     } else {
         let lhs = Datum::try_new(left)?;
-        let rhs = Datum::try_new(right)?;
+        let rhs = Datum::try_new_with_target_datatype(right, lhs.data_type())?;
 
         match operator {
             Operator::Eq => cmp::eq(&lhs, &rhs)?,

vortex-array/src/compute/like.rs

@@ -192,8 +192,10 @@ pub(crate) fn arrow_like(
         "Arrow Like: length mismatch for {}",
         array.encoding_id()
     );
+
+    // convert the pattern to the preferred array datatype
     let lhs = Datum::try_new(array)?;
-    let rhs = Datum::try_new(pattern)?;
+    let rhs = Datum::try_new_with_target_datatype(pattern, lhs.data_type())?;
 
     let result = match (options.negated, options.case_insensitive) {
         (false, false) => arrow_string::like::like(&lhs, &rhs)?,

vortex-array/src/compute/numeric.rs

@@ -254,7 +254,7 @@ fn arrow_numeric(
     let len = lhs.len();
 
     let left = Datum::try_new(lhs)?;
-    let right = Datum::try_new(rhs)?;
+    let right = Datum::try_new_with_target_datatype(rhs, left.data_type())?;
 
     let array = match operator {
         NumericOperator::Add => arrow_arith::numeric::add(&left, &right)?,