wip

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

bench-vortex/src/benchmark_driver.rs

@@ -152,7 +152,10 @@ pub fn run_benchmark<B: Benchmark>(benchmark: B, config: DriverConfig) -> Result
     )
 }
 
-#[allow(clippy::too_many_arguments)]
+#[expect(
+    clippy::too_many_arguments,
+    reason = "all arguments needed for benchmark execution"
+)]
 fn execute_queries<B: Benchmark>(
     queries: &[(usize, String)],
     iterations: usize,

bench-vortex/src/statpopgen/builder.rs

@@ -264,7 +264,6 @@ impl<'a> GnomADBuilder<'a> {
         }
     }
 
-    #[allow(clippy::cognitive_complexity)]
     pub fn consume_record(&mut self, header: &Header, record: &mut Record) -> VortexResult<()> {
         self.CHROM_builder
             .append_value(record.reference_sequence_name());
@@ -352,7 +351,6 @@ impl<'a> GnomADBuilder<'a> {
         Ok(())
     }
 
-    #[allow(clippy::cognitive_complexity)]
     pub fn consume_info(&mut self, header: &Header, info: Info) -> VortexResult<()> {
         info.iter(header)
             .process_results(|iter| -> VortexResult<()> {
@@ -376,7 +374,6 @@ impl<'a> GnomADBuilder<'a> {
             })?
     }
 
-    #[allow(clippy::cognitive_complexity)]
     pub fn finish(mut self) -> Result<RecordBatch, ArrowError> {
         let len = self.CHROM_builder.len();
         assert_eq!(len, self.POS_builder.len());

bench-vortex/src/tpch/dbgen.rs

@@ -74,7 +74,10 @@ impl DBGen {
 }
 
 impl DBGen {
-    #[allow(clippy::unwrap_in_result)]
+    #[expect(
+        clippy::unwrap_in_result,
+        reason = "benchmark code where unwrap is acceptable"
+    )]
     /// Generate the TPC-H data files for use with benchmarks.
     pub fn generate(&self) -> anyhow::Result<PathBuf> {
         let sh = Shell::new()?;

encodings/sparse/src/lib.rs

@@ -386,7 +386,6 @@ impl ValidityVTable<SparseVTable> for SparseVTable {
         array.patches().values().all_invalid()
     }
 
-    #[allow(clippy::unnecessary_fallible_conversions)]
     fn validity_mask(array: &SparseArray) -> Mask {
         let fill_is_valid = array.fill_scalar().is_valid();
         let values_validity = array.patches().values().validity_mask();

vortex-btrblocks/src/integer/dictionary.rs

@@ -44,7 +44,10 @@ macro_rules! typed_encode {
 }
 
 /// Compresses an integer array into a dictionary arrays according to attached stats.
-#[allow(clippy::cognitive_complexity)]
+#[expect(
+    clippy::cognitive_complexity,
+    reason = "complexity from match on all integer types"
+)]
 pub fn dictionary_encode(stats: &IntegerStats) -> DictArray {
     // We need to preserve the nullability somehow from the original
     let src_validity = stats.src.validity();

vortex-btrblocks/src/string.rs

@@ -41,14 +41,18 @@ pub struct StringStats {
 }
 
 /// Estimate the number of distinct strings in the var bin view array.
-#[allow(clippy::cast_possible_truncation)]
+
 fn estimate_distinct_count(strings: &VarBinViewArray) -> u32 {
     let views = strings.views();
     // Iterate the views. Two strings which are equal must have the same first 8-bytes.
     // NOTE: there are cases where this performs pessimally, e.g. when we have strings that all
     // share a 4-byte prefix and have the same length.
     let mut distinct = HashSet::with_capacity(views.len() / 2);
     views.iter().for_each(|&view| {
+        #[expect(
+            clippy::cast_possible_truncation,
+            reason = "approximate uniqueness with view prefix"
+        )]
         let len_and_prefix = view.as_u128() as u64;
         distinct.insert(len_and_prefix);
     });

vortex-datafusion/src/persistent/metrics.rs

@@ -167,7 +167,10 @@ fn df_gauge(name: String, value: usize) -> DatafusionMetricValue {
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "truncation is checked before cast"
+)]
 fn f_to_u(f: f64) -> Option<usize> {
     (f.is_finite() && f >= usize::MIN as f64 && f <= usize::MAX as f64).then(||
         // After the range check, truncation is guaranteed to keep the value in usize bounds.

vortex-gpu/src/rle_decompress.rs

@@ -76,7 +76,7 @@ impl<V: DeviceRepr + NativePType, I, O> GPUTask for RLETask<V, I, O> {
     }
 }
 
-#[allow(clippy::cognitive_complexity)]
+#[expect(clippy::cognitive_complexity, reason = "complexity from nested match_each_* macros")]
 pub fn new_task(
     rle: &RLEArray,
     ctx: Arc<CudaContext>,

vortex-layout/src/encoding.rs

@@ -28,7 +28,6 @@ pub trait LayoutEncoding: 'static + Send + Sync + Debug + private::Sealed {
 
     fn id(&self) -> LayoutEncodingId;
 
-    #[allow(clippy::too_many_arguments)]
     fn build(
         &self,
         dtype: &DType,

vortex-layout/src/vtable.rs

@@ -74,7 +74,6 @@ pub trait VTable: 'static + Sized + Send + Sync + Debug {
     ) -> VortexResult<crate::gpu::GpuLayoutReaderRef>;
 
     /// Construct a new [`Layout`] from the provided parts.
-    #[allow(clippy::too_many_arguments)]
     fn build(
         encoding: &Self::Encoding,
         dtype: &DType,