move patch chunk

Signed-off-by: Alexander Droste <[email protected]>

Author: 0ax1

encodings/alp/src/alp/compress.rs

@@ -4,7 +4,7 @@
 use std::mem::transmute;
 
 use itertools::Itertools;
-use vortex_array::arrays::PrimitiveArray;
+use vortex_array::arrays::{PrimitiveArray, patch_chunk};
 use vortex_array::patches::Patches;
 use vortex_array::validity::Validity;
 use vortex_array::vtable::ValidityHelper;
@@ -187,7 +187,7 @@ pub fn decompress_chunked(
                     <T>::decode_slice_inplace(chunk_slice, exponents);
 
                     let decoded_chunk: &mut [T] = unsafe { transmute(chunk_slice) };
-                    PrimitiveArray::patch_chunk(
+                    patch_chunk(
                         decoded_chunk,
                         patches_indices,
                         patches_values,

vortex-array/src/arrays/primitive/array/mod.rs

@@ -18,6 +18,8 @@ mod conversion;
 mod patch;
 mod top_value;
 
+pub use patch::patch_chunk;
+
 /// A primitive array that stores [native types][vortex_dtype::NativePType] in a contiguous buffer
 /// of memory, along with an optional validity child.
 ///

vortex-array/src/arrays/primitive/array/patch.rs

@@ -55,44 +55,44 @@ impl PrimitiveArray {
         }
         Self::new(own_values, patched_validity)
     }
+}
 
-    /// Patches a chunk of decoded values with the given patches.
-    ///
-    /// # Arguments
-    ///
-    /// * `decoded_values` - Mutable slice of decoded values to be patched
-    /// * `patches_indices` - Indices indicating which positions to patch
-    /// * `patches_values` - Values to apply at the patched indices
-    /// * `patches_offset` - Offset to subtract from patch indices
-    /// * `chunk_offsets_slice` - Slice containing offsets for each chunk
-    /// * `chunk_idx` - Index of the chunk to patch
-    #[inline]
-    pub fn patch_chunk<T, I, C>(
-        decoded_values: &mut [T],
-        patches_indices: &[I],
-        patches_values: &[T],
-        patches_offset: usize,
-        chunk_offsets_slice: &[C],
-        chunk_idx: usize,
-    ) where
-        T: NativePType,
-        I: UnsignedPType,
-        C: UnsignedPType,
-    {
-        let patches_start_idx = chunk_offsets_slice[chunk_idx].as_();
-        let patches_end_idx = if chunk_idx + 1 < chunk_offsets_slice.len() {
-            chunk_offsets_slice[chunk_idx + 1].as_()
-        } else {
-            patches_indices.len()
-        };
+/// Patches a chunk of decoded values.
+///
+/// # Arguments
+///
+/// * `decoded_values` - Mutable slice of decoded values to be patched
+/// * `patches_indices` - Indices indicating which positions to patch
+/// * `patches_values` - Values to apply at the patched indices
+/// * `patches_offset` - Offset to subtract from patch indices
+/// * `chunk_offsets_slice` - Slice containing offsets for each chunk
+/// * `chunk_idx` - Index of the chunk to patch
+#[inline]
+pub fn patch_chunk<T, I, C>(
+    decoded_values: &mut [T],
+    patches_indices: &[I],
+    patches_values: &[T],
+    patches_offset: usize,
+    chunk_offsets_slice: &[C],
+    chunk_idx: usize,
+) where
+    T: NativePType,
+    I: UnsignedPType,
+    C: UnsignedPType,
+{
+    let patches_start_idx = chunk_offsets_slice[chunk_idx].as_();
+    let patches_end_idx = if chunk_idx + 1 < chunk_offsets_slice.len() {
+        chunk_offsets_slice[chunk_idx + 1].as_()
+    } else {
+        patches_indices.len()
+    };
 
-        let chunk_start = chunk_idx * 1024;
-        for patches_idx in patches_start_idx..patches_end_idx {
-            let patched_value = patches_values[patches_idx];
-            let absolute_index: usize = patches_indices[patches_idx].as_() - patches_offset;
-            let chunk_relative_index = absolute_index - chunk_start;
-            decoded_values[chunk_relative_index] = patched_value;
-        }
+    let chunk_start = chunk_idx * 1024;
+    for patches_idx in patches_start_idx..patches_end_idx {
+        let patched_value = patches_values[patches_idx];
+        let absolute_index: usize = patches_indices[patches_idx].as_() - patches_offset;
+        let chunk_relative_index = absolute_index - chunk_start;
+        decoded_values[chunk_relative_index] = patched_value;
     }
 }
 

vortex-array/src/arrays/primitive/mod.rs

@@ -2,7 +2,7 @@
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
 mod array;
-pub use array::PrimitiveArray;
+pub use array::{PrimitiveArray, patch_chunk};
 
 mod compute;
 pub use compute::{IS_CONST_LANE_WIDTH, compute_is_constant};