Reduce optimizer logging to debug (#5702)

Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Nicholas Gates <[email protected]>
Co-authored-by: Joe Isaacs <[email protected]>

Author: gatesn

encodings/runend/src/rules.rs

@@ -73,12 +73,14 @@ impl ArrayParentReduceRule<Exact<RunEndVTable>, AnyScalarFn> for RunEndScalarFnR
                 .into_array();
 
         Ok(Some(
-            RunEndArray::try_new_offset_length(
-                run_end.ends().clone(),
-                new_values,
-                run_end.offset(),
-                run_end.len(),
-            )?
+            unsafe {
+                RunEndArray::new_unchecked(
+                    run_end.ends().clone(),
+                    new_values,
+                    run_end.offset(),
+                    run_end.len(),
+                )
+            }
             .into_array(),
         ))
     }

vortex-array/src/optimizer/mod.rs

@@ -87,7 +87,11 @@ impl ArrayOptimizer {
         // No real reason to pick 4.
         let max_iterations = array.depth_first_traversal().count() * 4;
 
-        inner(self, array, max_iterations)
+        tracing::debug!("Starting array optimization\n{}", array.display_tree());
+        let array = inner(self, array, max_iterations)?;
+        tracing::debug!("Optimized array\n{}", array.display_tree());
+
+        Ok(array)
     }
 
     /// Register a reduce rule for a specific array encoding.

vortex-layout/src/layouts/flat/reader.rs

@@ -16,7 +16,6 @@ use vortex_array::expr::Expression;
 use vortex_array::expr::Root;
 use vortex_array::mask::MaskExecutor;
 use vortex_array::serde::ArrayParts;
-use vortex_array::session::ArraySessionExt;
 use vortex_dtype::DType;
 use vortex_dtype::FieldMask;
 use vortex_error::VortexExpect;
@@ -134,7 +133,6 @@ impl LayoutReader for FlatReader {
         let array = self.array_future();
         let expr = expr.clone();
         let session = self.session.clone();
-        let optimizer = self.session.arrays().optimizer().clone();
 
         Ok(MaskFuture::new(mask.len(), async move {
             // TODO(ngates): if the mask density is low enough, or if the mask is dense within a range
@@ -151,13 +149,8 @@ impl LayoutReader for FlatReader {
             let array_mask = if *USE_VORTEX_OPERATORS {
                 // Apply the expression to the array.
                 let array = array.apply(&expr)?;
-
-                tracing::debug!("Filter Array:\n{}", array.display_tree());
-                let array = optimizer.optimize_array(&array)?;
-                tracing::info!("Optimized Filter Array:\n{}", array.display_tree());
-
                 // Evaluate the array into a mask.
-                let array_mask = array.execute_mask(&session)?;
+                let array_mask = array.execute_mask_optimized(&session)?;
                 mask.bitand(&array_mask)
             } else {
                 // TODO(ngates): the mask may actually be dense within a range, as is often the case when
@@ -213,7 +206,6 @@ impl LayoutReader for FlatReader {
         let name = self.name.clone();
         let array = self.array_future();
         let expr = expr.clone();
-        let optimizer = self.session.arrays().optimizer().clone();
 
         Ok(async move {
             tracing::debug!("Flat array evaluation {} - {}", name, expr);
@@ -235,9 +227,6 @@ impl LayoutReader for FlatReader {
                     array = array.filter(mask)?;
                 }
 
-                tracing::debug!("Project Array:\n{}", array.display_tree());
-                let array = optimizer.optimize_array(&array)?;
-                tracing::info!("Optimized Project Array:\n{}", array.display_tree());
                 array
             } else {
                 // Filter the array based on the row mask.