Skip to content

Commit afbc015

Browse files
chore[bench]: nightly sql bench with different targets (sf=100) (#3808)
Signed-off-by: Joe Isaacs <[email protected]>
1 parent eba8b28 commit afbc015

File tree

2 files changed

+54
-24
lines changed

2 files changed

+54
-24
lines changed

.github/workflows/nightly-bench.yml

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,31 @@ jobs:
1818
with:
1919
mode: 'develop'
2020
machine_type: ${{ matrix.machine_type.instance_name }}
21-
scale_factor: 10
21+
benchmark_matrix: |
22+
[
23+
{
24+
"id": "tpch-nvme",
25+
"subcommand": "tpch",
26+
"name": "TPC-H on NVME",
27+
"targets": ",datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex",
28+
"scale_factor": "--scale-factor 100"
29+
},
30+
{
31+
"id": "clickbench-nvme",
32+
"subcommand": "clickbench",
33+
"name": "Clickbench on NVME",
34+
"targets": "datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex,duckdb:duckdb",
35+
},
36+
{
37+
"id": "tpch-s3",
38+
"subcommand": "tpch",
39+
"name": "TPC-H on S3",
40+
"local_dir": "bench-vortex/data/tpch/100",
41+
"remote_storage": "s3://vortex-bench-dev-eu/develop/tpch/100/",
42+
"targets": "datafusion:parquet,datafusion:vortex,duckdb:parquet",
43+
"scale_factor": "--scale-factor 100"
44+
}
45+
]
2246
strategy:
2347
matrix:
2448
machine_type:

.github/workflows/sql-benchmarks.yml

Lines changed: 29 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,35 @@ on:
1010
required: false
1111
type: string
1212
default: c6id.8xlarge
13-
scale_factor:
13+
benchmark_matrix:
1414
required: false
15-
type: number
16-
default: 1
15+
type: string
16+
description: 'JSON string containing the matrix configuration'
17+
default: |
18+
[
19+
{
20+
"id": "tpch-nvme",
21+
"subcommand": "tpch",
22+
"name": "TPC-H on NVME",
23+
"targets": "datafusion:arrow,datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex,duckdb:duckdb",
24+
"scale_factor": "--scale-factor 1"
25+
},
26+
{
27+
"id": "clickbench-nvme",
28+
"subcommand": "clickbench",
29+
"name": "Clickbench on NVME",
30+
"targets": "datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex,duckdb:duckdb",
31+
},
32+
{
33+
"id": "tpch-s3",
34+
"subcommand": "tpch",
35+
"name": "TPC-H on S3",
36+
"local_dir": "bench-vortex/data/tpch/1",
37+
"remote_storage": "s3://vortex-bench-dev-eu/${{github.ref_name}}/tpch/1/",
38+
"targets": "datafusion:parquet,datafusion:vortex,duckdb:parquet",
39+
"scale_factor": "--scale-factor 1"
40+
}
41+
]
1742
1843
jobs:
1944
bench:
@@ -25,26 +50,7 @@ jobs:
2550
strategy:
2651
fail-fast: false
2752
matrix:
28-
# Regarding "include:":
29-
# https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#example-adding-configurations
30-
include:
31-
- id: tpch-nvme
32-
subcommand: tpch
33-
name: TPC-H on NVME
34-
targets: "datafusion:arrow,datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex,duckdb:duckdb"
35-
scale_factor: "--scale-factor ${{inputs.scale_factor}}"
36-
- id: clickbench-nvme
37-
subcommand: clickbench
38-
name: Clickbench on NVME
39-
targets: "datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex,duckdb:duckdb"
40-
scale_factor: ""
41-
- id: tpch-s3
42-
subcommand: tpch
43-
name: TPC-H on S3
44-
local_dir: bench-vortex/data/tpch/${{inputs.scale_factor}}
45-
remote_storage: s3://vortex-bench-dev-eu/${{github.ref_name}}/tpch/${{inputs.scale_factor}}/
46-
targets: "datafusion:parquet,datafusion:vortex,duckdb:parquet"
47-
scale_factor: "--scale-factor ${{inputs.scale_factor}}"
53+
include: ${{ fromJSON(inputs.benchmark_matrix) }}
4854

4955
runs-on:
5056
- runs-on=${{ github.run_id }}

0 commit comments

Comments
 (0)