wip

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

encodings/alp/src/alp/array.rs

@@ -385,7 +385,7 @@ impl EncodeVTable<ALPVTable> for ALPVTable {
 impl VisitorVTable<ALPVTable> for ALPVTable {
     fn visit_buffers(_array: &ALPArray, _visitor: &mut dyn ArrayBufferVisitor) {}
 
-    fn visit_children(array: &ALPArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a ALPArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_child("encoded", array.encoded());
         if let Some(patches) = array.patches() {
             visitor.visit_patches(patches);

encodings/alp/src/alp_rd/array.rs

@@ -413,7 +413,7 @@ impl EncodeVTable<ALPRDVTable> for ALPRDVTable {
 impl VisitorVTable<ALPRDVTable> for ALPRDVTable {
     fn visit_buffers(_array: &ALPRDArray, _visitor: &mut dyn ArrayBufferVisitor) {}
 
-    fn visit_children(array: &ALPRDArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a ALPRDArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_child("left_parts", array.left_parts());
         visitor.visit_child("right_parts", array.right_parts());
         if let Some(patches) = array.left_parts_patches() {

encodings/bytebool/src/array.rs

@@ -196,7 +196,7 @@ impl VisitorVTable<ByteBoolVTable> for ByteBoolVTable {
         visitor.visit_buffer(array.buffer());
     }
 
-    fn visit_children(array: &ByteBoolArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a ByteBoolArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_validity(array.validity(), array.len());
     }
 }

encodings/datetime-parts/src/array.rs

@@ -265,7 +265,7 @@ impl EncodeVTable<DateTimePartsVTable> for DateTimePartsVTable {
 impl VisitorVTable<DateTimePartsVTable> for DateTimePartsVTable {
     fn visit_buffers(_array: &DateTimePartsArray, _visitor: &mut dyn ArrayBufferVisitor) {}
 
-    fn visit_children(array: &DateTimePartsArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a DateTimePartsArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_child("days", array.days());
         visitor.visit_child("seconds", array.seconds());
         visitor.visit_child("subseconds", array.subseconds());

encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs

@@ -235,7 +235,10 @@ impl ValidityChild<DecimalBytePartsVTable> for DecimalBytePartsVTable {
 impl VisitorVTable<DecimalBytePartsVTable> for DecimalBytePartsVTable {
     fn visit_buffers(_array: &DecimalBytePartsArray, _visitor: &mut dyn ArrayBufferVisitor) {}
 
-    fn visit_children(array: &DecimalBytePartsArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(
+        array: &'a DecimalBytePartsArray,
+        visitor: &mut dyn ArrayChildVisitor<'a>,
+    ) {
         visitor.visit_child("msp", &array.msp);
     }
 }

encodings/fastlanes/src/bitpacking/vtable/visitor.rs

@@ -11,7 +11,7 @@ impl VisitorVTable<BitPackedVTable> for BitPackedVTable {
         visitor.visit_buffer(array.packed());
     }
 
-    fn visit_children(array: &BitPackedArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a BitPackedArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         if let Some(patches) = array.patches() {
             visitor.visit_patches(patches);
         }

encodings/fastlanes/src/delta/mod.rs

@@ -318,7 +318,7 @@ impl CanonicalVTable<DeltaVTable> for DeltaVTable {
 impl VisitorVTable<DeltaVTable> for DeltaVTable {
     fn visit_buffers(_array: &DeltaArray, _visitor: &mut dyn ArrayBufferVisitor) {}
 
-    fn visit_children(array: &DeltaArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a DeltaArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_child("bases", array.bases());
         visitor.visit_child("deltas", array.deltas());
     }

encodings/fastlanes/src/for/mod.rs

@@ -184,7 +184,7 @@ impl EncodeVTable<FoRVTable> for FoRVTable {
 impl VisitorVTable<FoRVTable> for FoRVTable {
     fn visit_buffers(_array: &FoRArray, _visitor: &mut dyn ArrayBufferVisitor) {}
 
-    fn visit_children(array: &FoRArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a FoRArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_child("encoded", array.encoded())
     }
 }

encodings/fastlanes/src/rle/mod.rs

@@ -371,7 +371,7 @@ impl VisitorVTable<RLEVTable> for RLEVTable {
         // RLE stores all data in child arrays, no direct buffers
     }
 
-    fn visit_children(array: &RLEArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a RLEArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_child("values", array.values());
         visitor.visit_child("indices", array.indices());
         visitor.visit_child("values_idx_offsets", array.values_idx_offsets());

encodings/fsst/src/array.rs

@@ -338,7 +338,7 @@ impl VisitorVTable<FSSTVTable> for FSSTVTable {
         visitor.visit_buffer(&array.symbol_lengths().clone().into_byte_buffer());
     }
 
-    fn visit_children(array: &FSSTArray, visitor: &mut dyn ArrayChildVisitor) {
+    fn visit_children<'a>(array: &'a FSSTArray, visitor: &mut dyn ArrayChildVisitor<'a>) {
         visitor.visit_child("codes", array.codes().as_ref());
         visitor.visit_child("uncompressed_lengths", array.uncompressed_lengths());
     }