I think that's it

Author: AdamGS

benchmarks/ddb-bench/src/lib.rs

@@ -37,7 +37,7 @@ impl DuckDBObject {
 pub struct DuckClient {
     pub db: Database,
     pub connection: Connection,
-    pub db_path: Option<PathBuf>,
+    pub db_path: PathBuf,
     pub threads: Option<usize>,
 }
 
@@ -49,22 +49,21 @@ impl DuckClient {
         delete_database: bool,
         threads: Option<usize>,
     ) -> Result<Self> {
-        let db_path = if data_url.scheme() != "file" {
-            None
-        } else {
-            let base_path = data_url
+        let base_path = if data_url.scheme() == "file" {
+            data_url
                 .to_file_path()
-                .map_err(|_| anyhow::anyhow!("Invalid file URL: {}", data_url))?;
-            let dir = base_path.join(format.name());
-            std::fs::create_dir_all(&dir)?;
-            let db_path = dir.join("duckdb.db");
-            if delete_database && db_path.exists() {
-                std::fs::remove_file(&db_path)?;
-            }
-            Some(db_path)
+                .map_err(|_| anyhow::anyhow!("Invalid file URL: {}", data_url))?
+        } else {
+            std::env::temp_dir().join("vortex-ddb-bench")
         };
+        let dir = base_path.join(format.name());
+        std::fs::create_dir_all(&dir)?;
+        let db_path = dir.join("duckdb.db");
+        if delete_database && db_path.exists() {
+            std::fs::remove_file(&db_path)?;
+        }
 
-        let (db, connection) = Self::open_and_setup_database(db_path.clone(), threads)?;
+        let (db, connection) = Self::open_and_setup_database(Some(db_path.clone()), threads)?;
 
         Ok(Self {
             db,
@@ -123,7 +122,7 @@ impl DuckClient {
         drop(db);
 
         let (mut db, mut connection) =
-            Self::open_and_setup_database(self.db_path.clone(), self.threads)?;
+            Self::open_and_setup_database(Some(self.db_path.clone()), self.threads)?;
 
         std::mem::swap(&mut self.connection, &mut connection);
         std::mem::swap(&mut self.db, &mut db);
@@ -132,11 +131,14 @@ impl DuckClient {
     }
 
     pub fn new_in_memory() -> Result<Self> {
-        let (db, connection) = Self::open_and_setup_database(None, None)?;
+        let dir = std::env::temp_dir().join("vortex-ddb-bench").join("in-memory");
+        std::fs::create_dir_all(&dir)?;
+        let db_path = dir.join("duckdb.db");
+        let (db, connection) = Self::open_and_setup_database(Some(db_path.clone()), None)?;
         Ok(Self {
             db,
             connection,
-            db_path: None,
+            db_path,
             threads: None,
         })
     }