fix?

Author: AdamGS

.github/workflows/sql-benchmarks.yml

@@ -246,7 +246,6 @@ jobs:
           OTEL_EXPORTER_OTLP_ENDPOINT: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_ENDPOINT || '' }}"
           OTEL_EXPORTER_OTLP_HEADERS: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_HEADERS || '' }}"
           OTEL_RESOURCE_ATTRIBUTES: "bench-name=${{ matrix.id }}"
-          RUST_LOG: "RUST_LOG=debug,vortex_io=off,hyper=off,datafusion=info,sqlparser=off"
         run: |
           # Extract formats for each engine
           df_formats=$(echo "${{ matrix.targets }}" | tr ',' '\n' | grep '^datafusion:' | sed 's/datafusion://' | tr '\n' ',' | sed 's/,$//')

benchmarks/ddb-bench/src/lib.rs

@@ -9,10 +9,10 @@ use std::time::Instant;
 
 use anyhow::Result;
 use tracing::trace;
-use url::Url;
 use vortex::error::VortexExpect;
 use vortex_bench::Benchmark;
 use vortex_bench::Format;
+use vortex_bench::IdempotentPath;
 use vortex_bench::generate_duckdb_registration_sql;
 use vortex_duckdb::duckdb::Config;
 use vortex_duckdb::duckdb::Connection;
@@ -30,17 +30,18 @@ pub struct DuckClient {
 impl DuckClient {
     /// Create a new DuckDB context with a database at `{data_url}/{format}/duckdb.db`.
     pub fn new(
-        data_url: &Url,
+        benchmark: &dyn Benchmark,
         format: Format,
         delete_database: bool,
         threads: Option<usize>,
     ) -> Result<Self> {
+        let data_url = benchmark.data_url();
         let base_path = if data_url.scheme() == "file" {
             data_url
                 .to_file_path()
                 .map_err(|_| anyhow::anyhow!("Invalid file URL: {}", data_url))?
         } else {
-            std::env::temp_dir().join("vortex-ddb-bench")
+            format!("{name}/{format}/", name = benchmark.dataset_name()).to_data_path()
         };
         let dir = base_path.join(format.name());
         std::fs::create_dir_all(&dir)?;

benchmarks/ddb-bench/src/main.rs

@@ -120,7 +120,7 @@ async fn main() -> anyhow::Result<()> {
         args.iterations,
         |format| {
             let ctx = DuckClient::new(
-                benchmark.data_url(),
+                &*benchmark,
                 format,
                 args.delete_duckdb_database,
                 args.threads,