wip

Signed-off-by: Alexander Droste <[email protected]>

Author: 0ax1

vortex-array/src/arrays/list/compute/take.rs

@@ -1,14 +1,14 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-use num_traits::ToPrimitive;
+use num_traits::AsPrimitive;
 use vortex_buffer::BitBufferMut;
 use vortex_dtype::IntegerPType;
 use vortex_dtype::Nullability;
-use vortex_dtype::{match_each_integer_ptype, match_smallest_offset_type};
+use vortex_dtype::match_each_integer_ptype;
+use vortex_dtype::match_smallest_offset_type;
 use vortex_error::VortexExpect;
 use vortex_error::VortexResult;
-use vortex_error::vortex_panic;
 use vortex_mask::Mask;
 
 use crate::Array;
@@ -48,17 +48,9 @@ impl TakeKernel for ListVTable {
                 let total_count = indices_slice
                     .iter()
                     .map(|idx| {
-                        let idx = idx.to_usize().unwrap_or_else(|| {
-                            vortex_panic!("Failed to convert index to usize: {}", idx)
-                        });
-                        (offsets_slice[idx + 1] - offsets_slice[idx])
-                            .to_usize()
-                            .unwrap_or_else(|| {
-                                vortex_panic!(
-                                    "Failed to convert offset difference to usize: {}",
-                                    offsets_slice[idx + 1] - offsets_slice[idx]
-                                )
-                            })
+                        let idx: usize = idx.as_();
+                        let diff: usize = (offsets_slice[idx + 1] - offsets_slice[idx]).as_();
+                        diff
                     })
                     .sum::<usize>();
 
@@ -106,9 +98,7 @@ fn _take<I: IntegerPType, O: IntegerPType, AccumType: IntegerPType>(
     new_offsets.append_zero();
 
     for &data_idx in indices {
-        let data_idx = data_idx
-            .to_usize()
-            .unwrap_or_else(|| vortex_panic!("Failed to convert index to usize: {}", data_idx));
+        let data_idx: usize = data_idx.as_();
 
         let start = offsets[data_idx];
         let stop = offsets[data_idx + 1];
@@ -118,21 +108,14 @@ fn _take<I: IntegerPType, O: IntegerPType, AccumType: IntegerPType>(
         // We could convert start and end to usize, but that would impose a potentially
         // harder constraint - now we don't care if they fit into usize as long as their
         // difference does.
-        let additional = (stop - start).to_usize().unwrap_or_else(|| {
-            vortex_panic!("Failed to convert range length to usize: {}", stop - start)
-        });
+        let additional: usize = (stop - start).as_();
 
         elements_to_take.reserve_exact(additional);
         for i in 0..additional {
             elements_to_take.append_value(start + O::from_usize(i).vortex_expect("i < additional"));
         }
-        current_offset += AccumType::from_usize((stop - start).to_usize().unwrap_or_else(|| {
-            vortex_panic!(
-                "Failed to convert offset difference to usize: {}",
-                stop - start
-            )
-        }))
-        .vortex_expect("offset conversion");
+        current_offset +=
+            AccumType::from_usize((stop - start).as_()).vortex_expect("offset conversion");
         new_offsets.append_value(current_offset);
     }
 
@@ -185,9 +168,7 @@ fn _take_nullable<I: IntegerPType, O: IntegerPType, AccumType: IntegerPType>(
             continue;
         }
 
-        let data_idx = data_idx
-            .to_usize()
-            .unwrap_or_else(|| vortex_panic!("Failed to convert index to usize: {}", data_idx));
+        let data_idx: usize = data_idx.as_();
 
         if !data_validity.value(data_idx) {
             new_offsets.append_value(current_offset);
@@ -199,21 +180,14 @@ fn _take_nullable<I: IntegerPType, O: IntegerPType, AccumType: IntegerPType>(
         let stop = offsets[data_idx + 1];
 
         // See the note it the `take` on the reasoning
-        let additional = (stop - start).to_usize().unwrap_or_else(|| {
-            vortex_panic!("Failed to convert range length to usize: {}", stop - start)
-        });
+        let additional: usize = (stop - start).as_();
 
         elements_to_take.reserve_exact(additional);
         for i in 0..additional {
             elements_to_take.append_value(start + O::from_usize(i).vortex_expect("i < additional"));
         }
-        current_offset += AccumType::from_usize((stop - start).to_usize().unwrap_or_else(|| {
-            vortex_panic!(
-                "Failed to convert offset difference to usize: {}",
-                stop - start
-            )
-        }))
-        .vortex_expect("offset conversion");
+        current_offset +=
+            AccumType::from_usize((stop - start).as_()).vortex_expect("offset conversion");
         new_offsets.append_value(current_offset);
         new_validity.set(idx);
     }