remove decimal/generic_mut_impl.rs

Signed-off-by: Connor Tsui <[email protected]>

Author: connortsui20

vortex-vector/src/decimal/generic_mut.rs

@@ -3,6 +3,7 @@
 
 use vortex_buffer::BufferMut;
 use vortex_dtype::{NativeDecimalType, PrecisionScale};
+use vortex_error::{VortexResult, vortex_bail};
 use vortex_mask::MaskMut;
 
 use crate::{DVector, VectorMutOps, VectorOps};
@@ -15,6 +16,49 @@ pub struct DVectorMut<D> {
     pub(super) validity: MaskMut,
 }
 
+impl<D: NativeDecimalType> DVectorMut<D> {
+    /// Get the precision/scale of the decimal vector.
+    pub fn precision_scale(&self) -> PrecisionScale<D> {
+        self.ps
+    }
+
+    /// Get a nullable element at the given index.
+    pub fn get(&self, index: usize) -> Option<&D> {
+        self.validity.value(index).then(|| &self.elements[index])
+    }
+
+    /// Appends a new element to the end of the vector.
+    ///
+    /// # Errors
+    ///
+    /// Returns an error if the value is out of bounds for the vector's precision/scale.
+    pub fn try_push(&mut self, value: D) -> VortexResult<()> {
+        if !self.ps.is_valid(value) {
+            vortex_bail!("Value {:?} is out of bounds for {}", value, self.ps,);
+        }
+
+        self.elements.push(value);
+        self.validity.append_n(true, 1);
+        Ok(())
+    }
+
+    /// Returns a mutable reference to the underlying elements buffer.
+    ///
+    /// # Safety
+    ///
+    /// Modifying the elements buffer directly may violate the precision/scale constraints.
+    /// The caller must ensure that any modifications maintain these invariants.
+    pub unsafe fn elements_mut(&mut self) -> &mut [D] {
+        &mut self.elements
+    }
+}
+
+impl<D: NativeDecimalType> AsRef<[D]> for DVectorMut<D> {
+    fn as_ref(&self) -> &[D] {
+        &self.elements
+    }
+}
+
 impl<D: NativeDecimalType> VectorMutOps for DVectorMut<D> {
     type Immutable = DVector<D>;
 

vortex-vector/src/decimal/generic_mut_impl.rs

@@ -5,7 +5,6 @@ mod generic;
 pub use generic::DVector;
 
 mod generic_mut;
-mod generic_mut_impl;
 pub use generic_mut::DVectorMut;
 
 mod vector;