Comparison compuite

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

vortex-compute/Cargo.toml

@@ -28,12 +28,7 @@ vortex-vector = { workspace = true }
 num-traits = { workspace = true }
 
 [features]
-default = [
-    "arithmetic",
-    "comparison",
-    "filter",
-    "logical",
-]
+default = ["arithmetic", "comparison", "filter", "logical"]
 
 arithmetic = []
 comparison = []

vortex-compute/src/arithmetic/mod.rs

@@ -100,84 +100,3 @@ macro_rules! impl_floats {
 impl_floats!(f16);
 impl_floats!(f32);
 impl_floats!(f64);
-
-/// Performs addition that returns None instead of wrapping around on overflow.
-pub trait CheckedAdd<Rhs = Self> {
-    /// The result type after performing the operation.
-    type Output;
-
-    /// Perform the operation.
-    fn checked_add(self, other: Rhs) -> Option<Self::Output>;
-}
-
-impl<A, Rhs, Output> CheckedAdd<Rhs> for A
-where
-    A: Checked<Add, Rhs, Output = Output>,
-{
-    type Output = Output;
-
-    fn checked_add(self, other: Rhs) -> Option<Self::Output> {
-        self.checked_op(other)
-    }
-}
-
-/// Performs subtraction that returns None instead of wrapping around on underflow.
-pub trait CheckedSub<Rhs = Self> {
-    /// The result type after performing the operation.
-    type Output;
-
-    /// Perform the operation.
-    fn checked_sub(self, other: Rhs) -> Option<Self::Output>;
-}
-
-impl<A, Rhs, Output> CheckedSub<Rhs> for A
-where
-    A: Checked<Sub, Rhs, Output = Output>,
-{
-    type Output = Output;
-
-    fn checked_sub(self, other: Rhs) -> Option<Self::Output> {
-        self.checked_op(other)
-    }
-}
-
-/// Performs multiplication that returns None instead of wrapping around on underflow or overflow.
-pub trait CheckedMul<Rhs = Self> {
-    /// The result type after performing the operation.
-    type Output;
-
-    /// Perform the operation.
-    fn checked_mul(self, other: Rhs) -> Option<Self::Output>;
-}
-
-impl<A, Rhs, Output> CheckedMul<Rhs> for A
-where
-    A: Checked<Mul, Rhs, Output = Output>,
-{
-    type Output = Output;
-
-    fn checked_mul(self, other: Rhs) -> Option<Self::Output> {
-        self.checked_op(other)
-    }
-}
-
-/// Performs division that returns None instead of panicking on division by zero and instead of
-/// wrapping around on underflow and overflow.
-pub trait CheckedDiv<Rhs = Self> {
-    /// The result type after performing the operation.
-    type Output;
-
-    /// Perform the operation.
-    fn checked_div(self, other: Rhs) -> Option<Self::Output>;
-}
-
-impl<A, Rhs, Output> CheckedDiv<Rhs> for A
-where
-    A: Checked<Div, Rhs, Output = Output>,
-{
-    type Output = Output;
-
-    fn checked_div(self, other: Rhs) -> Option<Self::Output> {
-        self.checked_op(other)
-    }
-}

vortex-compute/src/comparison/mod.rs

@@ -10,8 +10,6 @@ mod collection;
 mod pvector;
 
 /// Trait for comparison operations.
-///
-/// It may be easier to use the specific traits like [`CompareLessThan`], [`CompareGreaterThan`], etc.
 pub trait Compare<Op, Rhs = Self> {
     /// The result type after performing the operation.
     type Output;